[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Code defects in Plasma
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2008-09-22 18:28:32
Message-ID: 200809221229.39821.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 22 September 2008, Ivan Čukić wrote:
> > - amarok/src/context/plasma/animator.cpp:291
> > Division by 0 if frames < 3
>
> issue1.diff attached

hm.. i'm not even sure that '/ 3' is really needed anymore at all. or the '/ 
5' elsewhere as well.. i think it actually should be:

qMax(1, frames * (d->driver->animationDuration(animation) / 1000.0))

i'll make these changes just now ...

> > - amarok/src/context/plasma/containment.cpp:991
> > Line 986 indicates that focusedApplet can be NULL. But focusedApplet is
> > equal to applet. Therefore applet can be NULL here.
>
> This is in ContainmentPrivate::focusApplet (not line 986 anymore)
> issue2.diff attached

hm.. can ContainmentPrivate::applets ever contain NULL? i don't think so.

i'd rather have this written as:

if (applet && applets.contains(applet)) {

i may as well make that change while i'm looking at it as well ...

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech


["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]