--===============0575127414==
Content-Type: multipart/signed;
  boundary="nextPart3206177.jRVCugFmuR";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart3206177.jRVCugFmuR
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Monday 22 September 2008, Ivan =C4=8Cuki=C4=87 wrote:
> > - amarok/src/context/plasma/animator.cpp:291
> > Division by 0 if frames < 3
>
> issue1.diff attached

hm.. i'm not even sure that '/ 3' is really needed anymore at all. or the '=
/=20
5' elsewhere as well.. i think it actually should be:

qMax(1, frames * (d->driver->animationDuration(animation) / 1000.0))

i'll make these changes just now ...

> > - amarok/src/context/plasma/containment.cpp:991
> > Line 986 indicates that focusedApplet can be NULL. But focusedApplet is
> > equal to applet. Therefore applet can be NULL here.
>
> This is in ContainmentPrivate::focusApplet (not line 986 anymore)
> issue2.diff attached

hm.. can ContainmentPrivate::applets ever contain NULL? i don't think so.

i'd rather have this written as:

if (applet && applets.contains(applet)) {

i may as well make that change while i'm looking at it as well ...

=2D-=20
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech


--nextPart3206177.jRVCugFmuR
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEABECAAYFAkjX5BIACgkQ1rcusafx20NxtQCfaYmoi8iw85VZAwiR/eNcowbJ
PlQAniRJwfnyIX/5GU6YoH00W3zq6CgV
=uWOh
-----END PGP SIGNATURE-----

--nextPart3206177.jRVCugFmuR--

--===============0575127414==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============0575127414==--