[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Fwd: Re: Patch for Bug 168126 (set different icons size for each
From: Benjamin Kleiner <bizzl.greekdog () web ! de>
Date: 2008-09-04 18:31:37
Message-ID: 200809042031.38108.bizzl.greekdog () web ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hmmm... it's probably a bad idea to not send to the mailing list.
Sorry for the long delay, hope the diffs are still useful...
> i probably wasn't clear enough in my explanation, sorry =/ what i meant by
> "add a page to the dialog for each group" was to call parent->addPage for
> each set of configurations (see the parrent->addPage(widget,
> parent->windowTitle(), icon()); call currently there for an example). this
> will result in the proper display automagically following how the rest of
> plasma does it.
Oh, dumb me, sry.
I hacked this in within minutes, it works for me, but I can't really diff against the \
current svn without bloating the diff files, 'cause that wouldn't work anymore (can't \
set up a whole trunk build atm, my notebook would burn :( ), I hope that's okay.
> otherwise, i like it, though now we don't have to hide the filtering
> widgets as they don't take up a lot of space; instead they should just be
> enabled/disabled instead of shown/hidden.
Sure, no problem, is done in the attached patch.
[Attachment #5 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"> <html><head><meta name="qrichtext" \
content="1" /><style type="text/css"> p, li { white-space: pre-wrap; }
</style></head><body style=" font-family:'DejaVu Sans'; font-size:9pt; \
font-weight:400; font-style:normal;"> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">Hmmm... it's probably a bad idea to not send to the mailing \
list.</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Sorry for \
the long delay, hope the diffs are still useful...</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"></p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> i probably wasn't clear \
enough in my explanation, sorry =/ what i meant by</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">> "add a page to the dialog for each group" \
was to call parent->addPage for</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">> each set of configurations (see the \
parrent->addPage(widget,</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">> parent->windowTitle(), icon()); call currently there for \
an example). this</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> will \
result in the proper display automagically following how the rest of</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> plasma does it.</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Oh, dumb me, sry.</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">I hacked this in within \
minutes, it works for me, but I can't really diff against the current svn without \
bloating the diff files, 'cause that wouldn't work anymore (can't set up a </p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">whole trunk build atm, my \
notebook would burn :( ), I hope that's okay.</p> <p style="-qt-paragraph-type:empty; \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"></p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> otherwise, i like it, \
though now we don't have to hide the filtering</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">> widgets as they don't take up a lot of \
space; instead they should just be</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">> enabled/disabled instead of shown/hidden.</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Sure, no problem, is done in \
the attached patch.</p></body></html>
["folderview.patch.zip" (application/zip)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic