[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [PATCH] pass mouse wheel events to the wallpaper
From:       "Benoit Jacob" <jacob.benoit.1 () gmail ! com>
Date:       2008-09-04 18:13:30
Message-ID: d9f848520809041113ha1c9909lb00ecb0146d1c11f () mail ! gmail ! com
[Download RAW message or body]

OK, committed in 857101.

Benoit

2008/9/4 Aaron J. Seigo <aseigo@kde.org>:
> On Thursday 04 September 2008, Benoit Jacob wrote:
>> Hi,
>>
>> The attached patch makes Containment forward mouse wheel events first
>> to the wallpaper, if the event screenPos() indicates that the mouse
>> cursor was on the wallpaper. I adapted this code from what you were
>> already doing with mouseMoveEvent().
>
> cool ... two points:
>
> you need to re-accept the the event if the wallpaper ignores it; so this:
>
> if(event->isAccepted()) return;
>
> should be:
>
>    if (event->isAccepted()) {
>        return;
>    }
>
>    event->accept();
> }
>
> the second point is that the whitespace usage around the if statement is
> incorrectin your patch (and fixed in the example above)
>
> otherwise .. beauty =) please commit.
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Trolltech
>
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]