[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: plasma/kdelibs coding style and pointers
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2008-09-01 16:04:19
Message-ID: 200809011004.19904.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sunday 31 August 2008, Jason Stubbs wrote:
> The kdelibs coding style on techbase[1] only says "For pointers or
> references, use a single space before '*' or '&', but not after". When
> looking through applet.h and applet.cpp, I see this rule being broken in
> some circumstances. Am I right to believe that the first in each of the
> following groups is "correct"?

below are ones that are "correct"

> QString *p;

> void foo(QString *p);

> Blah * const d;

> QString* Blah::foo();

ones that i don't really care about:

> QList<Blah*> foo;
> QList<Blah *> foo;

and these are "wrong" because they should always have a variable name:

> void foo(QString*);
> void foo(QString *);

if you see code that isn't correct in svn, correct as you work around/near 
them and try and catch it before or directly after it goes into svn ..

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech


["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]