[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: plasma/kdelibs coding style and pointers
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2008-09-01 16:01:12
Message-ID: 200809011001.12767.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 01 September 2008, Jason Stubbs wrote:
> Jason Stubbs wrote:
> > The kdelibs coding style on techbase[1] only says "For pointers or
> > references, use a single space before '*' or '&', but not after". When
> > looking through applet.h and applet.cpp, I see this rule being broken in
> > some circumstances. Am I right to believe that the first in each of the
> > following groups is "correct"?
>
> The '&' case seems to be more tricky. In applet.cpp, I see:
>
> const QString &category
> const QString& reason
> const QSizeF & constraint
> KConfigGroup &group

the first and last one are "correct"

> Hmm, I'm also seeing both:
>
> QWidget *w =
> Applet* applet =

the first one is "correct"

> I'm wanting to standardize the coding style in the playground systray
> applet, but judging by the above (which are all from applet.cpp in
> libs/plasma) it seems that it's perhaps not worth the effort?

so because it's not perfect, let's make it worse? *blinks*

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech


["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]