[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Autohide options for PanelController
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2008-08-30 18:47:16
Message-ID: 20080830184716.12500.17178 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/166/
-----------------------------------------------------------

(Updated 2008-08-30 11:47:16.739354)


Review request for Plasma.


Summary
-------

this patch, really work in progress, adds a submenu in PanelController made with a \
Plasma::Dialog containing tha aligning options and the autohide/unerwindows options. \
done in a submenu because we were really at the limit for a 1024 (iirc hig says it \
still have to go well in 800x600?) so put less frequent actions here. Not sure about \
where put the panel alignment btw (so didn't sped much time on it, just moved) Also, \
didn't understood well how the autohide/letWindowsCover is supposed to work, since \
here letWindowsCover seems to not work at all. does make sense both option are \
activated?  autohide+letwindowscover could move the panel on top when the mouse \
cursor is at the edge of screen but not hide it when it leaves.

otherwise i could put 3 autoexclusive buttons "Normal" "Auto hide" and "Panel under \
Windows"


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.h
  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.cpp
  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.h
  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.cpp

Diff: http://reviewboard.vidsolbach.de/r/166/diff


Testing
-------


Screenshots
-----------

dialog open
  http://reviewboard.vidsolbach.de/r/166/s/53/


Thanks,

Marco

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]