[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: better behaviour when the tabbar is not a
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2008-08-30 18:09:08
Message-ID: 20080830180908.11361.71258 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/167/#review146
-----------------------------------------------------------

Ship it!


- Aaron


On 2008-08-30 10:13:57, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/167/
> -----------------------------------------------------------
> 
> (Updated 2008-08-30 10:13:57)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> the tabbar widget can behave both like a tabwidget and a plain tabbar, the \
> behaviour should be a bit different, in particular it did behave really bad when in \
> a panel. this patch removes the centering and makes the tabbar to take up all the \
> width when it's not like a tabwidget and there is some sizepolicy/preferred sizes \
> setting fixes that makes it behave better in a panel (especially vertical ones) \
> code probably doesn't look reeeally well, but in particular with that double \
> meaning of tabbar and tabwidget didn't come to my mind something more elegant :) 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/libs/plasma/private/nativetabbar.cpp
> /trunk/KDE/kdebase/workspace/libs/plasma/widgets/tabbar.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/167/diff
> 
> 
> Testing
> -------
> 
> tested in a panel as a plain tabbar (activitybar applet) and as a tabwidget \
> (weather applet) 
> 
> Thanks,
> 
> Marco
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]