[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: allow easier drops of applets onto panel - 165789
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2008-07-26 22:17:04
Message-ID: 20080726221704.31019.13696 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/75/#review90
-----------------------------------------------------------



/trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
<http://reviewboard.vidsolbach.de/r/75/#comment41>

    this should only accept items that match the applet mimetype or which are URLs; \
otherwise, looks good.


- Aaron


On None, Mario Oschwald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/75/
> -----------------------------------------------------------
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> small patch to fix
> 
> http://bugs.kde.org/show_bug.cgi?id=165789
> 
> and related bugs that complain about difficult to drop applets onto
> the panel.
> 
> I just (out of curiosity) accepted all DragMoveEvents in the panel
> and was then surprised that the panel (or rather containment) already
> handled the situation really well when a new applet is dropped on an old one.
> 
> One issue that came up, while playing around with this, is that taskbar
> items already accept (visually) all drops, even new applets, which then
> causes nothing to happen. Maybe drops should be disabled for taskbar
> items until those are really able to pass the events on to the respective
> application.
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.h
> /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/75/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mario
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]