[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: on the tabbar widget
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2008-07-26 22:01:38
Message-ID: 200807261601.39344.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Saturday 26 July 2008, Marco Martin wrote:
> i would like to merge in libplasma as soon as possible, so it really needs
> a review, i'm really not sure about several things, like:
> what level of wrapping should be provided by the tabbar proxywidget?
> now it wraps the addtab functions and the signal, too much?

it looks ok.. a TabWidget is pretty complex, so i don't see any realistic 
shortcuts here.

one thing i do wonder about, though, is whether or not we need/want both a 
TabBar and a TabWidget; i wonder if we could get away with just a TabWidget 
which behaves essentially like a TabBar if a null pointer is passed in for the 
content of a tab? would keep the number of classes down... what do you think? 
(i'm on the fence myself =)

> the QWidget should be made public?

hopefully not. it would be nice to just use the Plasma::Widgets in these other 
cases as well...

speaking of which, you shouldn't need to EXPORT the NativeTabBar class because 
of this...

> i would move the thing to kdereview? or just to libplama when it's ready?

when it's been reviewed, into libplasma.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech


["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]