[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Adapt Device Notifier to PopupApplet
From:       Marco Martin <notmart () gmail ! com>
Date:       2008-07-26 16:48:15
Message-ID: 200807261848.15260.notmart () gmail ! com
[Download RAW message or body]

On Saturday 26 July 2008, Alexis Ménard wrote:
> in h file i use a Plasma::Dialog (inherits of QWidget) and i do a new
> QWidget in desktop and a new Plasma::Dialog in taskbar...
>
> It's not a good way i think but there some stuff to do in plasma popup
> applet to avoid that...Perhaps we can take a look together in akademy...It
> can be done quickly...
i think popupapplet should also have a way to make popup with graphicsviews 
(like the notifier applet, like extenders.. using extenders perhaps?)
otherwise we wil ever only be able to do popups with plain qwidgets, a bit 
limiting...

Cheers,
Marco Martin

>
> On Sat, Jul 26, 2008 at 6:33 PM, Marco Martin <notmart@gmail.com> wrote:
> > On Saturday 26 July 2008, Alexis Ménard wrote:
> > > In branches/work/ter-notifier, i just use dialog when the applet is in
> > > a taskbar and i use a simple qwidget when the applet is in the
> > > desktop...
> > >
> > > It solves the double background painting...
> >
> > yeah, i like that :)
> >
> > Cheers,
> > Marco Martin
> >
> > > On Sat, Jul 26, 2008 at 6:17 PM, Marco Martin <notmart@gmail.com> wrote:
> > > > -----------------------------------------------------------
> > > > This is an automatically generated e-mail. To reply, visit:
> > > > http://reviewboard.vidsolbach.de/r/109/#review86
> > > > -----------------------------------------------------------
> > > >
> > > >
> > > > about putting plasma::Dialog into the desktop there would be only one
> > > > problem:
> > > > this applet would be forced to have no background and
> > > > reimplementations of popupapplet can not change its own background
> > > > hints
> > > > and on desktop the dialog svg would be displayed.
> > > > what i would do is:
> > > > use this patch nearly as is, but add a method (private with
> > > > popupapplet friend?) to Plasma::dialog to disable its own background,
> > > > so would
> >
> > still
> >
> > > > be popupapplet to draw the background.
> > > > would this cause other problems?
> > > >
> > > > - Marco
> > > >
> > > > On 2008-07-26 08:56:10, Loic Marteau wrote:
> > > > > -----------------------------------------------------------
> > > > > This is an automatically generated e-mail. To reply, visit:
> > > > > http://reviewboard.vidsolbach.de/r/109/
> > > > > -----------------------------------------------------------
> > > > >
> > > > > (Updated 2008-07-26 08:56:10)
> > > > >
> > > > >
> > > > > Review request for Plasma.
> > > > >
> > > > >
> > > > > Summary
> > > > > -------
> > > > >
> > > > > Here is a patch to adapt Device Notifier to use
> > > > > Plasma::PopupApplet.
> > > > >
> > > > > I have add some timer stuff in popupApplet so we can say how time
> > > > > we want
> > > >
> > > > popup the applet in panel.
> > > >
> > > > > I have change a little the way popupApplet work on Desktop mode by
> > > > > using
> > > >
> > > > the same Plasma::dialog widget than we use in Panel Mode.
> > > >
> > > > > Perhaps it is not a good idea ?!
> > > > >
> > > > > If we prefer not using Plasma:Dialog in Desktop mode i have to
> > > > > found
> >
> > a
> >
> > > > correct way to use the plasma theme inside the proxyWidget, which is
> >
> > not
> >
> > > > the case in the actual code.
> > > >
> > > > > Diffs
> > > > > -----
> > > > >
> > > > >   /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.h
> > > > >   /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.cpp
> >
> > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier
> >
> > > >.h
> >
> > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier
> >
> > > >.cpp
> > > >
> > > > > Diff: http://reviewboard.vidsolbach.de/r/109/diff
> > > > >
> > > > >
> > > > > Testing
> > > > > -------
> > > > >
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Loic
> > > >
> > > > _______________________________________________
> > > > Plasma-devel mailing list
> > > > Plasma-devel@kde.org
> > > > https://mail.kde.org/mailman/listinfo/plasma-devel


_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread]