[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [PATCH] RunnerManager
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2008-04-23 19:54:27
Message-ID: 200804231354.29233.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Wednesday 23 April 2008, Jordi Polo wrote:
> I hope I have addressed most of the issues with the first version. I
> deleted any code based on anything not decided (learning, priority list ).
> The methods regarding score in the AbstractRunner just slipped in the patch
> they are not supposed to be there.

getting a lot closer =)

other than the outstanding issues you mention, there's still the issue of 
launchQuery have both sync and async behaviour depending on what parameters 
are used. that needs to get split in two still.

> Also, the copy of the completer in searchcontext is commented and now I
> remember why. I spend today several hours trying to figure out why krunner
> will silently die (no way to debug) when typing one letter. As a result
> there are a zillion of kDebug everywhere and commenting that line make it
> works. It is not a solution, I need to know what is really happening.

it's getting deleted after being copied leaving a dangling pointer. kaboom. 

so in the copy ctor there you probably want something like:

completer = new KCompletion;
completer->setItems(other.d->completer->items());

except that that would likely be ugly on performance. best would be a way to 
share the dptr entirely using e.g. QExplicitlySharedDataPointer. that way all 
copies of the same SearchContext will use the same Private object.

> I have no tested the code that reads the configuration. I'll do it tomorrow
> if I find the time.

cool...

> There are still 3 signals. If I don't find a good reason for having
> matchesChanged, I'll kill it in a couple of weeks.

hopefully sooner than that even ;)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

["signature.asc" (application/pgp-signature)]

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]