[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [PATCH] RunnerManager
From:       "Jordi Polo" <mumismo () gmail ! com>
Date:       2008-04-23 18:51:54
Message-ID: a4162420804231151u18ee3729n1a4b1e124af651f2 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


A revised version of the patch here:
http://www.bahasara.org/raw-attachment/wiki/Papers/krunner_patch

The revision board failed saying when trying to upload:
'/srv/kde/mirror/kdebase/workspace/libs/plasma' is not a working copy Can't
open file '/srv/kde/mirror/kdebase/workspace/libs/plasma/.svn/entries': No
such file or directory

I hope I have addressed most of the issues with the first version. I deleted
any code based on anything not decided (learning, priority list ). The
methods regarding score in the AbstractRunner just slipped in the patch they
are not supposed to be there.

Also, the copy of the completer in searchcontext is commented and now I
remember why. I spend today several hours trying to figure out why krunner
will silently die (no way to debug) when typing one letter. As a result
there are a zillion of kDebug everywhere and commenting that line make it
works. It is not a solution, I need to know what is really happening.

I have no tested the code that reads the configuration. I'll do it tomorrow
if I find the time.
There are still 3 signals. If I don't find a good reason for having
matchesChanged, I'll kill it in a couple of weeks.
I hope it is closer to submit quality.


-- 
Jordi Polo Carres
NLP laboratory - NAIST
http://www.bahasara.org

[Attachment #5 (text/html)]

<br>A revised version of the patch here:<br><a \
href="http://www.bahasara.org/raw-attachment/wiki/Papers/krunner_patch">http://www.bahasara.org/raw-attachment/wiki/Papers/krunner_patch</a><br><br>The \
revision board failed saying when trying to upload:<br> \
&#39;/srv/kde/mirror/kdebase/workspace/libs/plasma&#39; is not a working copy \
Can&#39;t open file &#39;/srv/kde/mirror/kdebase/workspace/libs/plasma/.svn/entries&#39;: \
No such file or directory<br><br>I hope I have addressed most of the issues with the \
first version. I deleted any code based on anything not decided (learning, priority \
list ). The methods regarding score in the AbstractRunner just slipped in the patch \
they are not supposed to be there. <br> <br>Also, the copy of the completer in \
searchcontext is commented and now I remember why. I spend today several hours trying \
to figure out why krunner will silently die (no way to debug) when typing one letter. \
As a result there are a zillion of kDebug everywhere and commenting that line make it \
works. It is not a solution, I need to know what is really happening. <br> <br>I have \
no tested the code that reads the configuration. I&#39;ll do it tomorrow if I find \
the time.<br>There are still 3 signals. If I don&#39;t find a good reason for having \
matchesChanged, I&#39;ll kill it in a couple of weeks.<br> I hope it is closer to \
submit quality.<br><br clear="all"><br>-- <br>Jordi Polo Carres<br>NLP laboratory - \
NAIST<br><a href="http://www.bahasara.org">http://www.bahasara.org</a><br>



_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]