[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: [PATCH] Fifteen puzzle config revamp
From: Jesper Thomschutz <jesperht () yahoo ! com>
Date: 2008-01-22 20:20:31
Message-ID: 48110.81476.qm () web43145 ! mail ! sp1 ! yahoo ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi,
Feel free to make use of the wonderful world of OSS and improve the code as you see \
fit :) I appreciate the improvements that you guys are making to this applet.
Jesper, the neglecting father of the fifteen puzzle plasmoid
----- Original Message ----
From: Andre Magalhaes <andrunko@gmail.com>
To: panel-devel@kde.org
Sent: Tuesday, January 22, 2008 8:44:34 PM
Subject: Re: [PATCH] Fifteen puzzle config revamp
2008/1/22 Chani <chanika@gmail.com>:
>
> + while (m_pieces.at(rand) != NULL) {
> + rand = qrand() % 16;
> + }
>
> this... looks... Bad.
> I hate seeing any loop that has a random ending condition... what if
it never
> finishes?
> but I don't know the context, and it's past my bedtime so I'm just
gonna skip
> down to... oh! you already used configNeedsSaving() - awesome. :)
>
Yeah, I don't like this also, but this is not my code, and I didn't
touch it (besides
reindent it).
I tried to just fix the config dialog, and add the possibility to save
the config options.
Maybe this can be discussed with the applet "owner".
BR
--
Andre Moreira Magalhaes (andrunko)
--------------------------------------------------------
Jabber: andrunko@gmail.com
MSN: andremoreira@msn.com
Skype: andrunko
Blog: http://andrunko.blogspot.com
_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel
____________________________________________________________________________________
Looking for last minute shopping deals?
Find them fast with Yahoo! Search. \
http://tools.search.yahoo.com/newsearch/category.php?category=shopping
[Attachment #5 (text/html)]
<html><head><style type="text/css"><!-- DIV {margin:0px;} \
--></style></head><body><div style="font-family:times new roman, new york, times, \
serif;font-size:12pt"><div style="font-family: times new roman,new york,times,serif; \
font-size: 12pt;">Hi,<br>Feel free to make use of the wonderful world of OSS and \
improve the code as you see fit :)<br>I appreciate the improvements that you guys are \
making to this applet.<br><br>Jesper, the neglecting father of the fifteen puzzle \
plasmoid<br><br><br><div style="font-family: times new roman,new york,times,serif; \
font-size: 12pt;">----- Original Message ----<br>From: Andre Magalhaes \
<andrunko@gmail.com><br>To: panel-devel@kde.org<br>Sent: Tuesday, January 22, \
2008 8:44:34 PM<br>Subject: Re: [PATCH] Fifteen puzzle config revamp<br><br> \
2008/1/22 Chani <<a ymailto="mailto:chanika@gmail.com" \
href="mailto:chanika@gmail.com">chanika@gmail.com</a>>:<br>><br>> + \
while (<a target="_blank" href="http://m_pieces.at">m_pieces.at</a>(rand) != \
NULL) {<br>> + rand = qrand() % 16;<br>> + \
}<br>><br>> this... looks... Bad.<br>> I hate seeing any loop that has a \
random ending condition... what if it never<br>> finishes?<br>> but I don't \
know the context, and it's past my bedtime so I'm just gonna skip<br>> down to... \
oh! you already used configNeedsSaving() - awesome. :)<br>><br>Yeah, I don't like \
this also, but this is not my code, and I didn't<br>touch it (besides<br>reindent \
it).<br>I tried to just fix the config dialog, and add the possibility to save<br>the \
config options.<br>Maybe this can be discussed with the applet \
"owner".<br><br>BR<br><br>-- <br>Andre Moreira Magalhaes \
(andrunko)<br>--------------------------------------------------------<br>Jabber: <a \
ymailto="mailto:andrunko@gmail.com" \
href="mailto:andrunko@gmail.com">andrunko@gmail.com</a><br>MSN: <a \
ymailto="mailto:andremoreira@msn.com" \
href="mailto:andremoreira@msn.com">andremoreira@msn.com</a><br>Skype: \
andrunko<br>Blog: <a href="http://andrunko.blogspot.com" \
target="_blank">http://andrunko.blogspot.com</a><br>_______________________________________________<br>Panel-devel \
mailing list<br><a ymailto="mailto:Panel-devel@kde.org" \
href="mailto:Panel-devel@kde.org">Panel-devel@kde.org</a><br><a \
href="https://mail.kde.org/mailman/listinfo/panel-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/panel-devel</a><br></div><br></div></div><br>
<hr size=1>Never miss a thing. <a \
href="http://us.rd.yahoo.com/evt=51438/*http://www.yahoo.com/r/hs"> Make Yahoo your \
homepage.</a>
</body></html>
_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic