[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [PATCH] Fifteen puzzle config revamp
From:       Anne-Marie Mahfouf <annemarie.mahfouf () free ! fr>
Date:       2008-01-22 19:48:36
Message-ID: 200801222044.07125.annemarie.mahfouf () free ! fr
[Download RAW message or body]

Le Tuesday 22 January 2008 02:03:19 pm Andre Magalhaes, vous avez écrit  :

Hi Andre,

I tested the patch.
Looks very nice! Definitively cleaner!
Chani remarked on IRC that "splitted" is not English so we agreed to replace 
it with
"use custom image"

not-about-the-patch-but-still-about-15: The right click menu only works on the 
applet's border, not on the tiles (there's a bug report about it as if the 
applet is in the panel then there's no right click menu possible)
Anyone has an idea on how to solve that? 

Anne-Marie

> Here I am again. I am trying to get the config dialogs in a sane state.
> Another config dialog that was pissing me off was the Fifteen puzzle
> config dialog
> so I rewrote it.
>
> The code now besides the visual improvement, saves config options,
> so when you reload the applet it will use the saved options.
> I also reindented some part of the code to follow the applets code
> indentation
>
> Eg.: Added {  } to all if, while, for ...
>        Removed trailing whitespaces
>        ...
>
> Here are the screenshots of the old and new config dialog:
>
> Old config in the initial state:
> http://www.flickr.com/photos/andrunko/2212773400/
> Old config when "Split ..." option is selected:
> http://www.flickr.com/photos/andrunko/2212773404/
> Old config when "Plain .." option is selected again:
> http://www.flickr.com/photos/andrunko/2212773406/
>
> New config in the initial state:
> http://www.flickr.com/photos/andrunko/2212773410/
> New config when "Split ..." option is selected:
> http://www.flickr.com/photos/andrunko/2212773414/
>
> I  also added an action in the menu to shuffle the pieces.
>
> There is only one remaining issue in the new config dialog. I don't think
> a shuffle pieces button should be there, but I can't find a way to do
> it but in the menu (already added in the patch).
>
> Any feedback is welcome, if everybody agrees I will commit it.
>
> BR



_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel

[prev in list] [next in list] [prev in thread] [next in thread]