[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: [PATCH] Fifteen puzzle config revamp
From: "Hans Chen" <hanswchen () gmail ! com>
Date: 2008-01-22 19:25:52
Message-ID: c59230380801221125p6af2ea35o9e2238c77faf2121 () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi again Andre,
You're really doing a great work! (only judged by screenshots). The area I
personally think needs more work in KDE is on polishing. I really appreciate
small improvements like this only, it makes the whole experience much much
better.
I really wish I had more time, these kind of jobs seem like a good
introduction to KDE programming. Oh well, now back to topic.
> I also added an action in the menu to shuffle the pieces.
>
> There is only one remaining issue in the new config dialog. I don't think
> a shuffle pieces button should be there, but I can't find a way to do
> it but in the menu (already added in the patch).
When I saw the screenshots I was going to suggest this. In my opinion the
button belongs to a configuration dialog. I was thinking why it was there,
and not only in the right-click menu, and I think I have an answer:
discoverability. Yeah, actually you don't have to right click to bring up
the configure dialog which I thought first.
I don't know if that's a good reason though, personally I would just access
the action from the right click menu.
With best regards,
Hans Chen
2008/1/22 Andre Magalhaes <andrunko@gmail.com>:
> Hi all,
>
> Here I am again. I am trying to get the config dialogs in a sane state.
> Another config dialog that was pissing me off was the Fifteen puzzle
> config dialog
> so I rewrote it.
>
> The code now besides the visual improvement, saves config options,
> so when you reload the applet it will use the saved options.
> I also reindented some part of the code to follow the applets code
> indentation
>
> Eg.: Added { } to all if, while, for ...
> Removed trailing whitespaces
> ...
>
> Here are the screenshots of the old and new config dialog:
>
> Old config in the initial state:
> http://www.flickr.com/photos/andrunko/2212773400/
> Old config when "Split ..." option is selected:
> http://www.flickr.com/photos/andrunko/2212773404/
> Old config when "Plain .." option is selected again:
> http://www.flickr.com/photos/andrunko/2212773406/
>
> New config in the initial state:
> http://www.flickr.com/photos/andrunko/2212773410/
> New config when "Split ..." option is selected:
> http://www.flickr.com/photos/andrunko/2212773414/
>
> I also added an action in the menu to shuffle the pieces.
>
> There is only one remaining issue in the new config dialog. I don't think
> a shuffle pieces button should be there, but I can't find a way to do
> it but in the menu (already added in the patch).
>
> Any feedback is welcome, if everybody agrees I will commit it.
>
> BR
>
> --
> Andre Moreira Magalhaes (andrunko)
> --------------------------------------------------------
> Jabber: andrunko@gmail.com
> MSN: andremoreira@msn.com
> Skype: andrunko
> Blog: http://andrunko.blogspot.com
>
> _______________________________________________
> Panel-devel mailing list
> Panel-devel@kde.org
> https://mail.kde.org/mailman/listinfo/panel-devel
>
>
[Attachment #5 (text/html)]
Hi again Andre,<br><br>You're really doing a great work! (only judged \
by screenshots). The area I personally think needs more work in KDE is on \
polishing. I really appreciate small improvements like this only, it makes \
the whole experience much much better. <br>I really wish I had more time, \
these kind of jobs seem like a good introduction to KDE programming. Oh \
well, now back to topic.<br><br>> I also added an action in the \
menu to shuffle the pieces.<br>><br>> There is only one remaining \
issue in the new config dialog. I don't think <br>> a shuffle pieces \
button should be there, but I can't find a way to do<br>> it but in \
the menu (already added in the patch).<br><br>When I saw the screenshots I \
was going to suggest this. In my opinion the button belongs to a \
configuration dialog. I was thinking why it was there, and not only in the \
right-click menu, and I think I have an answer: discoverability. Yeah, \
actually you don't have to right click to bring up the configure dialog \
which I thought first. <br><br>I don't know if that's a good reason \
though, personally I would just access the action from the right click \
menu.<br><br>With best regards,<br>Hans Chen<br><br><div \
class="gmail_quote">2008/1/22 Andre Magalhaes < <a \
href="mailto:andrunko@gmail.com">andrunko@gmail.com</a>>:<br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); \
margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi all,<br><br>Here I am \
again. I am trying to get the config dialogs in a sane state. <br>Another \
config dialog that was pissing me off was the Fifteen puzzle<br>config \
dialog<br>so I rewrote it.<br><br>The code now besides the visual \
improvement, saves config options,<br>so when you reload the applet it will \
use the saved options. <br>I also reindented some part of the code to \
follow the applets code indentation<br><br>Eg.: Added { } to all if, \
while, for ...<br> Removed trailing whitespaces<br> \
...<br><br>Here are the screenshots of the old and new \
config dialog: <br><br>Old config in the initial state:<br><a \
href="http://www.flickr.com/photos/andrunko/2212773400/" \
target="_blank">http://www.flickr.com/photos/andrunko/2212773400/</a><br>Old \
config when "Split ..." option is selected: <br><a \
href="http://www.flickr.com/photos/andrunko/2212773404/" \
target="_blank">http://www.flickr.com/photos/andrunko/2212773404/</a><br>Old \
config when "Plain .." option is selected again:<br><a \
href="http://www.flickr.com/photos/andrunko/2212773406/" target="_blank"> \
http://www.flickr.com/photos/andrunko/2212773406/</a><br><br>New config in \
the initial state:<br><a \
href="http://www.flickr.com/photos/andrunko/2212773410/" \
target="_blank">http://www.flickr.com/photos/andrunko/2212773410/ \
</a><br>New config when "Split ..." option is selected:<br><a \
href="http://www.flickr.com/photos/andrunko/2212773414/" \
target="_blank">http://www.flickr.com/photos/andrunko/2212773414/</a><br><br>I \
also added an action in the menu to shuffle the pieces. <br><br>There \
is only one remaining issue in the new config dialog. I don't \
think<br>a shuffle pieces button should be there, but I can't find a \
way to do<br>it but in the menu (already added in the patch).<br><br> Any \
feedback is welcome, if everybody agrees I will commit \
it.<br><br>BR<br><font color="#888888"><br>--<br>Andre Moreira Magalhaes \
(andrunko)<br>--------------------------------------------------------<br>Jabber: \
<a href="mailto:andrunko@gmail.com"> andrunko@gmail.com</a><br>MSN: \
<a href="mailto:andremoreira@msn.com">andremoreira@msn.com</a><br>Skype: \
andrunko<br>Blog: <a href="http://andrunko.blogspot.com" \
target="_blank">http://andrunko.blogspot.com</a><br></font> \
<br>_______________________________________________<br>Panel-devel mailing \
list<br><a href="mailto:Panel-devel@kde.org">Panel-devel@kde.org</a><br><a \
href="https://mail.kde.org/mailman/listinfo/panel-devel" target="_blank"> \
https://mail.kde.org/mailman/listinfo/panel-devel</a><br><br></blockquote></div><br>
_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic