--===============0611538269==
Content-Type: multipart/alternative; 
	boundary="----=_Part_23437_26598422.1201029952870"

------=_Part_23437_26598422.1201029952870
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi again Andre,

You're really doing a great work! (only judged by screenshots). The area I
personally think needs more work in KDE is on polishing. I really appreciate
small improvements like this only, it makes the whole experience much much
better.
I really wish I had more time, these kind of jobs seem like a good
introduction to KDE programming. Oh well, now back to topic.

> I  also added an action in the menu to shuffle the pieces.
>
> There is only one remaining issue in the new config dialog. I don't think
> a shuffle pieces button should be there, but I can't find a way to do
> it but in the menu (already added in the patch).

When I saw the screenshots I was going to suggest this. In my opinion the
button belongs to a configuration dialog. I was thinking why it was there,
and not only in the right-click menu, and I think I have an answer:
discoverability. Yeah, actually you don't have to right click to bring up
the configure dialog which I thought first.

I don't know if that's a good reason though, personally I would just access
the action from the right click menu.

With best regards,
Hans Chen

2008/1/22 Andre Magalhaes <andrunko@gmail.com>:

> Hi all,
>
> Here I am again. I am trying to get the config dialogs in a sane state.
> Another config dialog that was pissing me off was the Fifteen puzzle
> config dialog
> so I rewrote it.
>
> The code now besides the visual improvement, saves config options,
> so when you reload the applet it will use the saved options.
> I also reindented some part of the code to follow the applets code
> indentation
>
> Eg.: Added {  } to all if, while, for ...
>       Removed trailing whitespaces
>       ...
>
> Here are the screenshots of the old and new config dialog:
>
> Old config in the initial state:
> http://www.flickr.com/photos/andrunko/2212773400/
> Old config when "Split ..." option is selected:
> http://www.flickr.com/photos/andrunko/2212773404/
> Old config when "Plain .." option is selected again:
> http://www.flickr.com/photos/andrunko/2212773406/
>
> New config in the initial state:
> http://www.flickr.com/photos/andrunko/2212773410/
> New config when "Split ..." option is selected:
> http://www.flickr.com/photos/andrunko/2212773414/
>
> I  also added an action in the menu to shuffle the pieces.
>
> There is only one remaining issue in the new config dialog. I don't think
> a shuffle pieces button should be there, but I can't find a way to do
> it but in the menu (already added in the patch).
>
> Any feedback is welcome, if everybody agrees I will commit it.
>
> BR
>
> --
> Andre Moreira Magalhaes (andrunko)
> --------------------------------------------------------
> Jabber: andrunko@gmail.com
> MSN:   andremoreira@msn.com
> Skype:  andrunko
> Blog:    http://andrunko.blogspot.com
>
> _______________________________________________
> Panel-devel mailing list
> Panel-devel@kde.org
> https://mail.kde.org/mailman/listinfo/panel-devel
>
>

------=_Part_23437_26598422.1201029952870
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi again Andre,<br><br>You&#39;re really doing a great work! (only judged by screenshots). The area I personally think needs more work in KDE is on polishing. I really appreciate small improvements like this only, it makes the whole experience much much better.
<br>I really wish I had more time, these kind of jobs seem like a good introduction to KDE programming. Oh well, now back to topic.<br><br>&gt; I &nbsp;also added an action in the menu to shuffle the pieces.<br>&gt;<br>&gt; There is only one remaining issue in the new config dialog. I don&#39;t think
<br>&gt; a shuffle pieces button should be there, but I can&#39;t find a way to do<br>&gt; it but in the menu (already added in the patch).<br><br>When I saw the screenshots I was going to suggest this. In my opinion the button belongs to a configuration dialog. I was thinking why it was there, and not only in the right-click menu, and I think I have an answer: discoverability. Yeah, actually you don&#39;t have to right click to bring up the configure dialog which I thought first.
<br><br>I don&#39;t know if that&#39;s a good reason though, personally I would just access the action from the right click menu.<br><br>With best regards,<br>Hans Chen<br><br><div class="gmail_quote">2008/1/22 Andre Magalhaes &lt;
<a href="mailto:andrunko@gmail.com">andrunko@gmail.com</a>&gt;:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi all,<br><br>Here I am again. I am trying to get the config dialogs in a sane state.
<br>Another config dialog that was pissing me off was the Fifteen puzzle<br>config dialog<br>so I rewrote it.<br><br>The code now besides the visual improvement, saves config options,<br>so when you reload the applet it will use the saved options.
<br>I also reindented some part of the code to follow the applets code indentation<br><br>Eg.: Added { &nbsp;} to all if, while, for ...<br> &nbsp; &nbsp; &nbsp; Removed trailing whitespaces<br> &nbsp; &nbsp; &nbsp; ...<br><br>Here are the screenshots of the old and new config dialog:
<br><br>Old config in the initial state:<br><a href="http://www.flickr.com/photos/andrunko/2212773400/" target="_blank">http://www.flickr.com/photos/andrunko/2212773400/</a><br>Old config when &quot;Split ...&quot; option is selected:
<br><a href="http://www.flickr.com/photos/andrunko/2212773404/" target="_blank">http://www.flickr.com/photos/andrunko/2212773404/</a><br>Old config when &quot;Plain ..&quot; option is selected again:<br><a href="http://www.flickr.com/photos/andrunko/2212773406/" target="_blank">
http://www.flickr.com/photos/andrunko/2212773406/</a><br><br>New config in the initial state:<br><a href="http://www.flickr.com/photos/andrunko/2212773410/" target="_blank">http://www.flickr.com/photos/andrunko/2212773410/
</a><br>New config when &quot;Split ...&quot; option is selected:<br><a href="http://www.flickr.com/photos/andrunko/2212773414/" target="_blank">http://www.flickr.com/photos/andrunko/2212773414/</a><br><br>I &nbsp;also added an action in the menu to shuffle the pieces.
<br><br>There is only one remaining issue in the new config dialog. I don&#39;t think<br>a shuffle pieces button should be there, but I can&#39;t find a way to do<br>it but in the menu (already added in the patch).<br><br>
Any feedback is welcome, if everybody agrees I will commit it.<br><br>BR<br><font color="#888888"><br>--<br>Andre Moreira Magalhaes (andrunko)<br>--------------------------------------------------------<br>Jabber: <a href="mailto:andrunko@gmail.com">
andrunko@gmail.com</a><br>MSN: &nbsp; <a href="mailto:andremoreira@msn.com">andremoreira@msn.com</a><br>Skype: &nbsp;andrunko<br>Blog: &nbsp; &nbsp;<a href="http://andrunko.blogspot.com" target="_blank">http://andrunko.blogspot.com</a><br></font>
<br>_______________________________________________<br>Panel-devel mailing list<br><a href="mailto:Panel-devel@kde.org">Panel-devel@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/panel-devel" target="_blank">
https://mail.kde.org/mailman/listinfo/panel-devel</a><br><br></blockquote></div><br>

------=_Part_23437_26598422.1201029952870--

--===============0611538269==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel

--===============0611538269==--