[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [PATCH] Standardize clocks config dialogs
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2008-01-21 17:20:55
Message-ID: 200801211020.55452.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 21 January 2008, Andre Magalhaes wrote:
> The new config is based on the digital-clock config. I believe all
> clocks config should use the same layout, and should add the possibility
> to use the local timezone.

agreed.

> I also changed the strings "Show seconds", "Display seconds" to be the same
> across the clocks config.

great =)

> > btw, you can also do ui.localTimeZone->checkState() == Qt::Checked as
> > ui.localTimeZone->isChecked()  ..
>
> I just used the same code as in digital-clock, should I change both?

yeah...

> > good job on following the coding style,
> > though; patch looks rather clean =)
>
> Tnx :)

ok, so, on to the GUI part of it. i don't like tabs. there, i said it. and i 
feel so much better for it. ;)

seriously though, i think we'd be better off in this situation using two flat 
groupboxes. see the config pages in konsole for an example of this style...

so it would end up looking sth like:

*Appearance*
[  ] Display seconds
[  ] Also display time in text

*Timezones*
[  ] Use local time zone
----------------- List Box ---------

---------------------------------------

thoughts?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

["signature.asc" (application/pgp-signature)]

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]