[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [PATCH] Standardize clocks config dialogs
From:       "Andre Magalhaes" <andrunko () gmail ! com>
Date:       2008-01-21 16:26:11
Message-ID: 7b3e4da90801210826y5de1c417n5113ca129b5bbd1a () mail ! gmail ! com
[Download RAW message or body]

Resending as the first one did went trough as the attachments
were big :).

2008/1/20 Aaron J. Seigo <aseigo@kde.org>:
> please post a screenshot so everyone can see the visual differences. this is
> what we encourage for visual changes.
Old config:
http://www.flickr.com/photos/andrunko/2209737372/
New config appearance tab:
http://www.flickr.com/photos/andrunko/2209737378/
New config timezones tab:
http://www.flickr.com/photos/andrunko/2209737382/

The new config is based on the digital-clock config. I believe all
clocks config should use the same layout, and should add the possibility
to use the local timezone.
I also changed the strings "Show seconds", "Display seconds" to be the same
across the clocks config.
IMHO the binary-clock config dialog on kdereview needs some love also, before
it moves to extragear :). See mail on kde-core-devel

> btw, you can also do ui.localTimeZone->checkState() == Qt::Checked as
> ui.localTimeZone->isChecked()  ..
I just used the same code as in digital-clock, should I change both?

> good job on following the coding style,
> though; patch looks rather clean =)
Tnx :)

-- 
Andre Moreira Magalhaes (andrunko)
--------------------------------------------------------
Jabber: andrunko@gmail.com
MSN:   andremoreira@msn.com
Skype:  andrunko
Blog:    http://andrunko.blogspot.com
_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel
[prev in list] [next in list] [prev in thread] [next in thread]