[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: [Panel-devel] Svg::elementRect and theme configs
From: "Leo Franchi" <lfranchi () gmail ! com>
Date: 2007-07-31 23:41:01
Message-ID: c5793d500707311641i6c4d3b56s748b1da41ac0f54d () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On 7/31/07, Aaron J. Seigo <aseigo@kde.org> wrote:
>
> On Tuesday 31 July 2007, Leo Franchi wrote:
> > API). So basically in order to get the correct element rect, i had to
> > add the two lines included in the patch.
>
> it *looks* ok (i'm in the middle of recompilling trunk/ on my lappie (at
> the
> airport), so can't easily check right now).. have you tested with the
> analog
> clock and url applets in plasma to make sure they don't break anything
> there?
the only applet which uses elementRect currently is the Script applet,
and it does indeed break that :-/
I'm going to try to figure out exactly why that is so...
> Also, regarding the current Theme->setApplicationName(), currently if you
> > set the application to, say, "amarok", plasma will look for the
> > [Theme-amarok] group in plasmarc. Now, as Amarok doesn't depend on
> kdebase,
> > there might not be a plasmarc at all.
>
> that doesn't matter, as it will be created as needed.
>
> > So it makes little sense for us to
> > edit/create plasmarc if none exists. I think it would be a better idea
> to
> > look into the application-default config, so amarokrc would hold the
> > relevant theme data. What do you guys think?
>
> as long as it can be done without breaking, for instance, krunner which
> relies
> on plasmarc being used. that's why it is as it is. i don't see the
> probably
> really? if it's a performance issue that you are concerned about i'd
> recommend benchmarking it first =)
the only concern is that it was a little strange for a user,
installing amarok on a kdebase-less system, would have a plasmarc with
his amarok-specific theme selection.
leo
--
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Trolltech
>
> _______________________________________________
> Panel-devel mailing list
> Panel-devel@kde.org
> https://mail.kde.org/mailman/listinfo/panel-devel
>
>
>
--
______________________________________________________
Leo Franchi angel666@myrealbox.com
4305 Charlemagne Ct lfranchi@gmail.com
Austin cell: (650) 704 3680
TX, USA home: (650) 329 0125
[Attachment #5 (text/html)]
<br><br><div><span class="gmail_quote">On 7/31/07, <b class="gmail_sendername">Aaron \
J. Seigo</b> <<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>> \
wrote:</span><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; \
margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; \
border-left-width: 1px; border-left-style: solid; padding-left: 1ex"> On Tuesday 31 \
July 2007, Leo Franchi wrote:<br>> API). So basically in order to get the correct \
element rect, i had to<br>> add the two lines included in the patch.<br><br>it \
*looks* ok (i'm in the middle of recompilling trunk/ on my lappie (at the \
<br>airport), so can't easily check right now).. have you tested with the \
analog<br>clock and url applets in plasma to make sure they don't break anything \
there?</blockquote><div><br><br>the only applet which uses el \
ementRect currently is the Script applet, and it does indeed break that :-/
</div>I'm going to try to figure out exactly why that is \
so...<br><br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; \
margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; \
border-left-width: 1px; border-left-style: solid; padding-left: 1ex"> > Also, \
regarding the current Theme->setApplicationName(), currently if you<br>> set \
the application to, say, "amarok", plasma will look for the<br>> \
[Theme-amarok] group in plasmarc. Now, as Amarok doesn't depend on kdebase, \
<br>> there might not be a plasmarc at all.<br><br>that doesn't matter, as it \
will be created as needed.<br><br>> So it makes little sense for us to<br>> \
edit/create plasmarc if none exists. I think it would be a better idea to <br>> \
look into the application-default config, so amarokrc would hold the<br>> relevant \
theme data. What do you guys think?<br><br>as long as it can be done without \
breaking, for instance, krunner which relies<br>on plasmarc being used. that's \
why it is as it is. i don't see the probably <br>really? if it's a \
performance issue that you are concerned about i'd<br>recommend benchmarking it \
first =)</blockquote><div><br>the only concern is that it&nbs \
p;was a little strange for a user, installing \
amarok on a kdebase-less system, would have a plasmarc with his amarok-specific theme selection.
<br><br>leo </div><br><blockquote class="gmail_quote" style="margin-top: 0; \
margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; \
border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; \
padding-left: 1ex">
--<br>Aaron J. Seigo<br>humru othro a kohnu se<br>GPG Fingerprint: 8B8B 2209 0C6F \
7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43<br><br>KDE core developer sponsored by \
Trolltech<br><br>_______________________________________________ <br>Panel-devel \
mailing list<br><a href="mailto:Panel-devel@kde.org">Panel-devel@kde.org</a><br><a \
href="https://mail.kde.org/mailman/listinfo/panel-devel">https://mail.kde.org/mailman/listinfo/panel-devel</a><br><br><br>
</blockquote></div><br><br clear="all"><br>-- \
<br>______________________________________________________<br>Leo \
Franchi <a \
href="mailto:angel666@myrealbox.com">angel666@myrealbox.com</a><br>4305 Charlemagne \
Ct <a \
href="mailto:lfranchi@gmail.com">lfranchi@gmail.com</a> \
<br>Austin &nbs \
p; \
cell: (650) 704 3680<br>TX, \
USA   \
; home: \
(650) 329 0125
_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic