From kde-panel-devel Tue Jul 31 23:41:01 2007 From: "Leo Franchi" Date: Tue, 31 Jul 2007 23:41:01 +0000 To: kde-panel-devel Subject: Re: [Panel-devel] Svg::elementRect and theme configs Message-Id: X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=118592530400532 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1276448003==" --===============1276448003== Content-Type: multipart/alternative; boundary="----=_Part_56147_28825677.1185925261847" ------=_Part_56147_28825677.1185925261847 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On 7/31/07, Aaron J. Seigo wrote: > > On Tuesday 31 July 2007, Leo Franchi wrote: > > API). So basically in order to get the correct element rect, i had to > > add the two lines included in the patch. > > it *looks* ok (i'm in the middle of recompilling trunk/ on my lappie (at > the > airport), so can't easily check right now).. have you tested with the > analog > clock and url applets in plasma to make sure they don't break anything > there? the only applet which uses elementRect currently is the Script applet, and it does indeed break that :-/ I'm going to try to figure out exactly why that is so... > Also, regarding the current Theme->setApplicationName(), currently if you > > set the application to, say, "amarok", plasma will look for the > > [Theme-amarok] group in plasmarc. Now, as Amarok doesn't depend on > kdebase, > > there might not be a plasmarc at all. > > that doesn't matter, as it will be created as needed. > > > So it makes little sense for us to > > edit/create plasmarc if none exists. I think it would be a better idea > to > > look into the application-default config, so amarokrc would hold the > > relevant theme data. What do you guys think? > > as long as it can be done without breaking, for instance, krunner which > relies > on plasmarc being used. that's why it is as it is. i don't see the > probably > really? if it's a performance issue that you are concerned about i'd > recommend benchmarking it first =) the only concern is that it was a little strange for a user, installing amarok on a kdebase-less system, would have a plasmarc with his amarok-specific theme selection. leo -- > Aaron J. Seigo > humru othro a kohnu se > GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 > > KDE core developer sponsored by Trolltech > > _______________________________________________ > Panel-devel mailing list > Panel-devel@kde.org > https://mail.kde.org/mailman/listinfo/panel-devel > > > -- ______________________________________________________ Leo Franchi angel666@myrealbox.com 4305 Charlemagne Ct lfranchi@gmail.com Austin cell: (650) 704 3680 TX, USA home: (650) 329 0125 ------=_Part_56147_28825677.1185925261847 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline

On 7/31/07, Aaron J. Seigo <aseigo@kde.org> wrote:

On Tuesday 31 July 2007, Leo Franchi wrote:
> API). So basically in order to get the correct element rect, i had to
> add the two lines included in the patch.

it *looks* ok (i'm in the middle of recompilling trunk/ on my lappie (at the
airport), so can't easily check right now).. have you tested with the analog
clock and url applets in plasma to make sure they don't break anything there?

the only applet which uses elementRect currently is the Script applet, and it does indeed break that :-/

I'm going to try to figure out exactly why that is so...

> Also, regarding the current Theme->setApplicationName(), currently if you
> set the application to, say, "amarok", plasma will look for the
> [Theme-amarok] group in plasmarc. Now, as Amarok doesn't depend on kdebase,
> there might not be a plasmarc at all.

that doesn't matter, as it will be created as needed.

> So it makes little sense for us to
> edit/create plasmarc if none exists. I think it would be a better idea to
> look into the application-default config, so amarokrc would hold the
> relevant theme data. What do you guys think?

as long as it can be done without breaking, for instance, krunner which relies
on plasmarc being used. that's why it is as it is. i don't see the probably
really? if it's a performance issue that you are concerned about i'd
recommend benchmarking it first =)

the only concern is that it was a little strange for a user, installing amarok on a kdebase-less system, would have a plasmarc with his amarok-specific theme selection.

leo

--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel

--
______________________________________________________
Leo Franchi                    angel666@myrealbox.com
4305 Charlemagne Ct         lfranchi@gmail.com
Austin                                 cell: (650) 704 3680
TX, USA                              home: (650) 329 0125 ------=_Part_56147_28825677.1185925261847-- --===============1276448003== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Panel-devel mailing list Panel-devel@kde.org https://mail.kde.org/mailman/listinfo/panel-devel --===============1276448003==--