[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [Panel-devel] KDE/kdebase/workspace
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2007-07-27 21:10:47
Message-ID: 200707271510.48059.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thursday 26 July 2007, Laurent Montel wrote:
> SVN commit 693020 by mlaurent:
>
> Allow to lock applet position
>
>
>  M  +19 -0     libs/plasma/applet.cpp
>  M  +9 -0      libs/plasma/applet.h
>  M  +6 -0      plasma/plasma/desktopview.cpp

besides the fact that this commit does not follow the coding guidelines (e.g. 
uses tabs instead of spaces), was not peer reviewed (that i know of?) and 
introduces new public API without apidox ........

... why do we want to lock the position of an applet? yes, i know SK did this, 
but i don't see the use case for it in plasma. can you provide a reason why 
we should offer "Lock" in the context menu?

the patch is also broken in numerous ways, primarily surrounding kiosk and 
immutability. *if* we offer per-applet locking, it should simply call 
setImmutable.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

[Attachment #5 (application/pgp-signature)]

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]