[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [Panel-devel] KDE/kdebase/workspace
From:       Barış_Metin <baris () pardus ! org ! tr>
Date:       2007-03-03 0:21:48
Message-ID: 200703030221.49138.baris () pardus ! org ! tr
[Download RAW message or body]

"Aaron J. Seigo" <aseigo@kde.org>: 
> > +	/**
> > +	 * Static method is called to load and get a list available of Runners.
> > +	 */
> > +	static List loadRunners( QWidget* parent );
> > +
>
> what you can't see easily in the above is that tabs are used.

My fault, I didn't notice it as I have the below code for emacs and it worked 
fine before.

;; Don't use tabs in any text-mode
(add-hook 'text-mode-hook
	  (lambda ()
	    (setq indent-tabs-mode nil)))

I've just added another one hoping that it won't break.

(add-hook 'before-save-hook
          (lambda ()
            (untabify (point-min) (point-max))))

> i'm seeing a number of commits that are not following the coding standard
> for krunner and plasma. this must stop.
>
> in krunner, we use the kdelibs style:
>
> 	http://techbase.kde.org/Policies/Kdelibs_Coding_Style
>
> in plasma we use the style i've used in kicker for the last few years,
> which is well documented in workspace/plasma/README.

One question as we're on it now. I've also seen some style inconsistency to 
HACKING file. Many are related to spacing between parenthesis. Should we obey 
the rules in HACKING file (no space between open/close parens) or should we 
follow the consistent usage in the file (eg. runner.h)?

> these are new applications, there is no excuse for the code to be
> inconsistent.

Sorry for the inconvenience :(. 

regards,
-- 
Barış Metin
_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel

[prev in list] [next in list] [prev in thread] [next in thread]