[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: [jan.smid@student.uni-magdeburg.de: Bug#28076: arts crashes when playing system sounds (windows
From:       Stefan Westerfeld <stefan () space ! twc ! de>
Date:       2001-07-22 10:25:45
[Download RAW message or body]

   Hi!

There are two issues with the patch:

 - it doesn't give immediate feedback to the user when messages are repeating
   (i.e. you don't know whether a message is repeating and repeating all the
   time, because you only see the first version of it, until another message
   pops up)

 - it makes the debugging routines non-thread-safe, because it adds static
   variables

The first is not too important, and it can be corrected later (after KDE2.2),
if somebody wants to solve this.

The thread safety issue can be solved by adding a mutex, and I think it should
be done, because I would like to be able to use the debugging routines like
arts_debug or arts_return_if_fail even in code that doesn't run in the main
thread.

If you know how to do this, please do and repost the patch, if not, go ahead
and apply the patch, and I'll add the mutex.

   Cu... Stefan

On Tue, Jul 17, 2001 at 11:18:16AM -0400, Jeff Tranter wrote:
> Attached is a patch which displays repeated duplicate messages only once.
> I also looked at using KUniqueApplication in artsmessage, but this looked
> like a better solution. It it looks okay I will commit it.
> 
> On July 13, 2001 12:35 pm, you wrote:
> >    Hi!
> >
> > I think the fact that you can easily bring down your whole system with a
> > message flood is definitely a show stopper for 2.2. Do you want to look at
> > fixing this?
> >
> > My very very approximate idea how to do this is that we should somehow
> > prevent another aRts message from being popped up unless the first is done,
> > maybe some KUniqueApplication thing (like noatun does) would do the trick.
> >
> > It might also make sense to gather similar messages and display them like
> >
> >   "some stupid error occured    (22)"
> >
> > if the same message keeps on repeating again and again.
> >
> >    Cu... Stefan
> >
> > -----Forwarded message from jan.smid@student.uni-magdeburg.de-----
> >
> > Received: from master.kde.org (max.tat.physik.uni-tuebingen.de
> > [134.2.170.93]) by space.twc.de (8.8.7/8.8.7) with SMTP id JAA23020
> > 	for <stefan@space.twc.de>; Wed, 4 Jul 2001 09:33:05 +0200
> > Received: (qmail 14338 invoked by uid 1003); 4 Jul 2001 07:33:05 -0000
> > Subject: Bug#28076: arts crashes when playing system sounds (windows open
> > etc.) Reply-To: 28076@bugs.kde.org
> > Resent-From: jan.smid@student.uni-magdeburg.de
> > Resent-To: kde-bugs-dist@max.tat.physik.uni-tuebingen.de
> > Resent-CC: Stefan Westerfeld <stefan@space.twc.de>
> > Resent-Date: Wed, 04 Jul 2001 07:33:04 GMT
> > Resent-Message-ID: <handler.28076.B.99423168513830@bugs.kde.org>
> > Resent-Sender: coolo@kde.org
> > X-KDE-PR-Message: report 28076
> > X-KDE-PR-Package: arts
> > X-Loop: owner@bugs.kde.org
> > Received: via spool by bugs@bugs.kde.org id=B.99423168513830
> >           (code B ref -1); Wed, 04 Jul 2001 07:33:04 GMT
> > Date: 4 Jul 2001 07:26:57 -0000
> > Message-ID: <20010704072657.13827.qmail@master.kde.org>
> > To: submit@bugs.kde.org
> > From: jan.smid@student.uni-magdeburg.de
> >
> > Package: arts
> > Version: KDE 2.2.0 Beta1
> > Severity: normal
> > Installed from:    SuSE RPMs
> > Compiler:          Not Specified
> > OS:                Linux
> > OS/Compiler notes: Suse 7.0, XF 4.0.3, PIII
> >
> > When I select the acqua style, arts displays the following message: "can't
> > open /home/test/.kde2/apps/share/sounds: file format not supported/"
> > artsmessage repeats this until the I have to exit X, because of swapping.
> >
> > (Submitted via bugs.kde.org)
> >
> > -----End of forwarded message-----



-- 
  -* Stefan Westerfeld, stefan@space.twc.de (PGP!), Hamburg/Germany
     KDE Developer, project infos at http://space.twc.de/~stefan/kde *-         
_______________________________________________
Kde-multimedia mailing list
Kde-multimedia@master.kde.org
http://master.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread]