[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-multimedia
Subject: Re: Review Request 120664: Revert "clang compat fix (from Qt)"
From: "Harald Sitter" <sitter () kde ! org>
Date: 2014-10-20 6:53:02
Message-ID: 20141020065302.18179.4187 () probe ! kde ! org
[Download RAW message or body]
--===============7089388499399665356==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120664/#review68739
-----------------------------------------------------------
Ship it!
Ship It!
- Harald Sitter
On Oct. 19, 2014, 9:18 p.m., Raphael Kubo da Costa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120664/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2014, 9:18 p.m.)
>
>
> Review request for Phonon.
>
>
> Repository: phonon
>
>
> Description
> -------
>
> The original Qt commit (3cba3745, "Phonon: Export ObjectDescriptionModel
> to prevent link errors with Clang") was a workaround for
> http://llvm.org/bugs/show_bug.cgi?id=8177, which was fixed more than 4
> years ago.
>
> Now that we have proper support for clang in Phonon and build it with
> -fvisibility=hidden, the workaround started causing problems, as
> ObjectDescriptionModel::staticObject and others were not being exported
> as expected. A quick test for this is building Qt's phonon capabilities
> example.
>
> This reverts commit 845e395ab3aba10dbd57207ad71fbbd6b422f107.
>
>
> Diffs
> -----
>
> phonon/objectdescriptionmodel.h 74339b5e64ee1ee48b8b2f783157b566a7f5c3f1
>
> Diff: https://git.reviewboard.kde.org/r/120664/diff/
>
>
> Testing
> -------
>
> Built Qt4's examples/phonon/capabilities successfully.
>
>
> Thanks,
>
> Raphael Kubo da Costa
>
>
--===============7089388499399665356==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120664/">https://git.reviewboard.kde.org/r/120664/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre> <br />
<p>- Harald Sitter</p>
<br />
<p>On October 19th, 2014, 9:18 p.m. UTC, Raphael Kubo da Costa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Phonon.</div>
<div>By Raphael Kubo da Costa.</div>
<p style="color: grey;"><i>Updated Oct. 19, 2014, 9:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
phonon
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The original Qt commit (3cba3745, "Phonon: Export \
ObjectDescriptionModel to prevent link errors with Clang") was a workaround for
http://llvm.org/bugs/show_bug.cgi?id=8177, which was fixed more than 4
years ago.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Now that we have proper support for clang in Phonon \
and build it with
-fvisibility=hidden, the workaround started causing problems, as
ObjectDescriptionModel::staticObject and others were not being exported
as expected. A quick test for this is building Qt's phonon capabilities
example.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This reverts commit \
845e395ab3aba10dbd57207ad71fbbd6b422f107.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Built Qt4's examples/phonon/capabilities \
successfully.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>phonon/objectdescriptionmodel.h <span style="color: \
grey">(74339b5e64ee1ee48b8b2f783157b566a7f5c3f1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120664/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7089388499399665356==--
_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic