--===============6811207201488495233== Content-Type: multipart/alternative; boundary="===============7089388499399665356==" --===============7089388499399665356== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120664/#review68739 ----------------------------------------------------------- Ship it! Ship It! - Harald Sitter On Oct. 19, 2014, 9:18 p.m., Raphael Kubo da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120664/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2014, 9:18 p.m.) > > > Review request for Phonon. > > > Repository: phonon > > > Description > ------- > > The original Qt commit (3cba3745, "Phonon: Export ObjectDescriptionModel > to prevent link errors with Clang") was a workaround for > http://llvm.org/bugs/show_bug.cgi?id=8177, which was fixed more than 4 > years ago. > > Now that we have proper support for clang in Phonon and build it with > -fvisibility=hidden, the workaround started causing problems, as > ObjectDescriptionModel::staticObject and others were not being exported > as expected. A quick test for this is building Qt's phonon capabilities > example. > > This reverts commit 845e395ab3aba10dbd57207ad71fbbd6b422f107. > > > Diffs > ----- > > phonon/objectdescriptionmodel.h 74339b5e64ee1ee48b8b2f783157b566a7f5c3f1 > > Diff: https://git.reviewboard.kde.org/r/120664/diff/ > > > Testing > ------- > > Built Qt4's examples/phonon/capabilities successfully. > > > Thanks, > > Raphael Kubo da Costa > > --===============7089388499399665356== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120664/

Ship it!

Ship It!

- Harald Sitter

On October 19th, 2014, 9:18 p.m. UTC, Raphael Kubo da Costa wrote:

Review request for Phonon.

By Raphael Kubo da Costa.

Updated Oct. 19, 2014, 9:18 p.m.

Repository: phonon

Description

The original Qt commit (3cba3745, "Phonon: Export ObjectDescriptionModel to prevent link errors with Clang") was a workaround for http://llvm.org/bugs/show_bug.cgi?id=8177, which was fixed more than 4 years ago.

Now that we have proper support for clang in Phonon and build it with -fvisibility=hidden, the workaround started causing problems, as ObjectDescriptionModel::staticObject and others were not being exported as expected. A quick test for this is building Qt's phonon capabilities example.

This reverts commit 845e395ab3aba10dbd57207ad71fbbd6b422f107.

Testing

Built Qt4's examples/phonon/capabilities successfully.

Diffs

phonon/objectdescriptionmodel.h (74339b5e64ee1ee48b8b2f783157b566a7f5c3f1)

--===============7089388499399665356==-- --===============6811207201488495233== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-multimedia mailing list kde-multimedia@kde.org https://mail.kde.org/mailman/listinfo/kde-multimedia --===============6811207201488495233==--