'Re: Review Request 113125: display a notification when JuK starts docked in system tray'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: Review Request 113125: display a notification when JuK starts docked in system tray
From:       "Shubham Chaudhary" <shubhamchaudhary92 () gmail ! com>
Date:       2013-10-06 23:22:17
Message-ID: 20131006232217.29160.11500 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113125/
-----------------------------------------------------------

(Updated Oct. 7, 2013, 4:52 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Multimedia and Michael Pyne.

Bugs: 316832
    http://bugs.kde.org/show_bug.cgi?id=316832

Repository: juk

Description
-------

To display a notification explaining steps to restore JuK back from system tray.

Bug 316832 - JuK starts off miminized to tray, which is confusing--no main window is seen

Diffs
-----

  juk.notifyrc cf4df1b 
  main.cpp d542403 

Diff: http://git.reviewboard.kde.org/r/113125/diff/

Testing
-------

Manually tested multiple times using KDE Development Platform 4.11.2

Thanks,

Shubham Chaudhary

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113125/">http://git.reviewboard.kde.org/r/113125/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px \
gray solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This \
change has been marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;">  <tr>
  <td>

<div>Review request for KDE Multimedia and Michael Pyne.</div>
<div>By Shubham Chaudhary.</div>

<p style="color: grey;"><i>Updated Oct. 7, 2013, 4:52 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=316832">316832</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
juk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">To display a notification explaining steps to restore JuK back \
from system tray.

Bug 316832 - JuK starts off miminized to tray, which is confusing--no main \
window is seen</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manually tested multiple times using KDE Development Platform \
4.11.2</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>juk.notifyrc <span style="color: grey">(cf4df1b)</span></li>

 <li>main.cpp <span style="color: grey">(d542403)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113125/diff/" \
style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread] 