[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-multimedia
Subject: Re: Review Request 113125: display a notification when JuK starts docked in system tray
From: "Shubham Chaudhary" <shubhamchaudhary92 () gmail ! com>
Date: 2013-10-06 22:27:35
Message-ID: 20131006222735.19679.75972 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 7, 2013, 3:53 a.m., Michael Pyne wrote:
> > This patch looks good, are you able to commit Shubham?
No, I don't have the permissions yet. Can you please do it for me.
- Shubham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113125/#review41312
-----------------------------------------------------------
On Oct. 6, 2013, 5:21 a.m., Shubham Chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113125/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2013, 5:21 a.m.)
>
>
> Review request for KDE Multimedia and Michael Pyne.
>
>
> Bugs: 316832
> http://bugs.kde.org/show_bug.cgi?id=316832
>
>
> Repository: juk
>
>
> Description
> -------
>
> To display a notification explaining steps to restore JuK back from system tray.
>
> Bug 316832 - JuK starts off miminized to tray, which is confusing--no main window is seen
>
>
> Diffs
> -----
>
> juk.notifyrc cf4df1b
> main.cpp d542403
>
> Diff: http://git.reviewboard.kde.org/r/113125/diff/
>
>
> Testing
> -------
>
> Manually tested multiple times using KDE Development Platform 4.11.2
>
>
> Thanks,
>
> Shubham Chaudhary
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113125/">http://git.reviewboard.kde.org/r/113125/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <p style="margin-top: 0;">On October 7th, 2013, 3:53 \
a.m. IST, <b>Michael Pyne</b> wrote:</p> <blockquote style="margin-left: \
1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre \
style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch \
looks good, are you able to commit Shubham?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, I \
don't have the permissions yet. Can you please do it for me.</pre> <br \
/>
<p>- Shubham</p>
<br />
<p>On October 6th, 2013, 5:21 a.m. IST, Shubham Chaudhary wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for KDE Multimedia and Michael Pyne.</div>
<div>By Shubham Chaudhary.</div>
<p style="color: grey;"><i>Updated Oct. 6, 2013, 5:21 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=316832">316832</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
juk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">To display a notification explaining steps to restore JuK back \
from system tray.
Bug 316832 - JuK starts off miminized to tray, which is confusing--no main \
window is seen</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manually tested multiple times using KDE Development Platform \
4.11.2</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>juk.notifyrc <span style="color: grey">(cf4df1b)</span></li>
<li>main.cpp <span style="color: grey">(d542403)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113125/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic