'Re: Review Request 112076: Fix bug where monitor won't powersave even with only audio content'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: Review Request 112076: Fix bug where monitor won't powersave even with only audio content
From:       "James Smith" <smithjd15 () gmail ! com>
Date:       2013-09-04 22:41:07
Message-ID: 20130904224107.31615.84213 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112076/
-----------------------------------------------------------

(Updated Sept. 4, 2013, 10:41 p.m.)

Review request for KDE Multimedia and Harald Sitter.

Changes
-------

No main window tinkering. This patch highlighted an issue where the MSN XMPP login \
window won't stop showing up in fullscreen mode over the video window despite \
KNotificationRestrictions which I thought broken during relocating to videoWindow. \
This ended up being in common with git master so hopefully that wasn't an issue and, \
the function could end up deprecated successfully in favour of the simplified \
suppressScreenPowerManagement behaviour, or retained until more options become \
available to suppress such notifications.

Description
-------

Fixes an issue where playing audio content keeps the screen awake. Video content is \
supposed to, but with the new play URL button, dragon should allow the monitor to \
turn off.

Diffs (updated)
-----

  src/app/audioView2.h 6c04b47 
  src/app/audioView2.cpp f2ddc44 
  src/app/mainWindow.h 51ef72c 
  src/app/mainWindow.cpp f850820 
  src/app/stateChange.cpp 0edde72 
  src/app/videoWindow.h ab61ed0 
  src/app/videoWindow.cpp a325a6e 

Diff: http://git.reviewboard.kde.org/r/112076/diff/

Testing
-------

Compile, run-test

Thanks,

James Smith

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112076/">http://git.reviewboard.kde.org/r/112076/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Multimedia and Harald Sitter.</div>
<div>By James Smith.</div>

<p style="color: grey;"><i>Updated Sept. 4, 2013, 10:41 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No main window tinkering. This patch highlighted an issue where the MSN \
XMPP login window won&#39;t stop showing up in fullscreen mode over the video window \
despite KNotificationRestrictions which I thought broken during relocating to \
videoWindow. This ended up being in common with git master so hopefully that \
wasn&#39;t an issue and, the function could end up deprecated successfully in favour \
of the simplified suppressScreenPowerManagement behaviour, or retained until more \
options become available to suppress such notifications.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes an issue where playing audio content keeps the screen awake. Video \
content is supposed to, but with the new play URL button, dragon should allow the \
monitor to turn off.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compile, run-test</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/app/audioView2.h <span style="color: grey">(6c04b47)</span></li>

 <li>src/app/audioView2.cpp <span style="color: grey">(f2ddc44)</span></li>

 <li>src/app/mainWindow.h <span style="color: grey">(51ef72c)</span></li>

 <li>src/app/mainWindow.cpp <span style="color: grey">(f850820)</span></li>

 <li>src/app/stateChange.cpp <span style="color: grey">(0edde72)</span></li>

 <li>src/app/videoWindow.h <span style="color: grey">(ab61ed0)</span></li>

 <li>src/app/videoWindow.cpp <span style="color: grey">(a325a6e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112076/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread] 