--===============8588923442482593672== Content-Type: multipart/alternative; boundary="===============1651289721825081169==" --===============1651289721825081169== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112076/ ----------------------------------------------------------- (Updated Sept. 4, 2013, 10:41 p.m.) Review request for KDE Multimedia and Harald Sitter. Changes ------- No main window tinkering. This patch highlighted an issue where the MSN XMPP login window won't stop showing up in fullscreen mode over the video window despite KNotificationRestrictions which I thought broken during relocating to videoWindow. This ended up being in common with git master so hopefully that wasn't an issue and, the function could end up deprecated successfully in favour of the simplified suppressScreenPowerManagement behaviour, or retained until more options become available to suppress such notifications. Description ------- Fixes an issue where playing audio content keeps the screen awake. Video content is supposed to, but with the new play URL button, dragon should allow the monitor to turn off. Diffs (updated) ----- src/app/audioView2.h 6c04b47 src/app/audioView2.cpp f2ddc44 src/app/mainWindow.h 51ef72c src/app/mainWindow.cpp f850820 src/app/stateChange.cpp 0edde72 src/app/videoWindow.h ab61ed0 src/app/videoWindow.cpp a325a6e Diff: http://git.reviewboard.kde.org/r/112076/diff/ Testing ------- Compile, run-test Thanks, James Smith --===============1651289721825081169== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112076/

Review request for KDE Multimedia and Harald Sitter.
By James Smith.

Updated Sept. 4, 2013, 10:41 p.m.

Changes

No main window tinkering. This patch highlighted an issue where the MSN XMPP login window won't stop showing up in fullscreen mode over the video window despite KNotificationRestrictions which I thought broken during relocating to videoWindow. This ended up being in common with git master so hopefully that wasn't an issue and, the function could end up deprecated successfully in favour of the simplified suppressScreenPowerManagement behaviour, or retained until more options become available to suppress such notifications.

Description 

Fixes an issue where playing audio content keeps the screen awake. Video content is supposed to, but with the new play URL button, dragon should allow the monitor to turn off.

Testing 

Compile, run-test

Diffs (updated)

  • src/app/audioView2.h (6c04b47)
  • src/app/audioView2.cpp (f2ddc44)
  • src/app/mainWindow.h (51ef72c)
  • src/app/mainWindow.cpp (f850820)
  • src/app/stateChange.cpp (0edde72)
  • src/app/videoWindow.h (ab61ed0)
  • src/app/videoWindow.cpp (a325a6e)

View Diff
--===============1651289721825081169==-- --===============8588923442482593672== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-multimedia mailing list kde-multimedia@kde.org https://mail.kde.org/mailman/listinfo/kde-multimedia --===============8588923442482593672==--