'Re: Review Request: Simplify layout of popup window to allow it grow when a new stream is added'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: Review Request: Simplify layout of popup window to allow it grow when a new stream is added
From:       "Christian Esken" <esken () kde ! org>
Date:       2013-01-02 19:01:33
Message-ID: 20130102190133.10549.13697 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107822/#review24480
-----------------------------------------------------------

I am a bit reluctant to remove the QWidgetAction, as it was the result of a very \
lengthy bug hunt through many parts of KDE, including Plasma. See \
https://bugs.kde.org/show_bug.cgi?id=220621#c27 for the background. And \
m_dockWidget->deleteLater() is still present. I will still test the patch, as we \
definitely need a fix and it is still very attractive to get rid of that strange \
QWidgetAction construct. Tests will include the following cases:  a) Without tray \
icon  b) With tray icon, without Sound Menu
 c) With tray icon, with Sound Menu

- Christian Esken

On Dec. 20, 2012, 8:20 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107822/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2012, 8:20 p.m.)
> 
> 
> Review request for KDE Multimedia and Christian Esken.
> 
> 
> Description
> -------
> 
> Eliminate QWidgetAction from popup window that allows popup window to change its \
> size. For instance, when a new stream is added, it grows now. 
> This might help to avoid recreation of the View \
> (http://commits.kde.org/kmix/1dfbbeb37fe03ed58b7be8ecdf22b376e3633830) that in turn \
> might help with https://bugs.kde.org/show_bug.cgi?id=311167 ? 
> 
> This addresses bug 288637.
> http://bugs.kde.org/show_bug.cgi?id=288637
> 
> 
> Diffs
> -----
> 
> gui/kmixdockwidget.h 0109086 
> gui/kmixdockwidget.cpp 3bda22e 
> 
> Diff: http://git.reviewboard.kde.org/r/107822/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107822/">http://git.reviewboard.kde.org/r/107822/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am a bit reluctant to \
remove the QWidgetAction, as it was the result of a very lengthy bug hunt through \
many parts of KDE, including Plasma. See \
https://bugs.kde.org/show_bug.cgi?id=220621#c27 for the background. And \
m_dockWidget-&gt;deleteLater() is still present. I will still test the patch, as we \
definitely need a fix and it is still very attractive to get rid of that strange \
QWidgetAction construct. Tests will include the following cases:  a) Without tray \
icon  b) With tray icon, without Sound Menu
 c) With tray icon, with Sound Menu
</pre>
 <br />

<p>- Christian</p>

<br />
<p>On December 20th, 2012, 8:20 p.m., Eugene Shalygin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Multimedia and Christian Esken.</div>
<div>By Eugene Shalygin.</div>

<p style="color: grey;"><i>Updated Dec. 20, 2012, 8:20 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Eliminate QWidgetAction from popup window that allows popup window to \
change its size. For instance, when a new stream is added, it grows now.

This might help to avoid recreation of the View \
(http://commits.kde.org/kmix/1dfbbeb37fe03ed58b7be8ecdf22b376e3633830) that in turn \
might help with https://bugs.kde.org/show_bug.cgi?id=311167 ?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manual</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=288637">288637</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>gui/kmixdockwidget.h <span style="color: grey">(0109086)</span></li>

 <li>gui/kmixdockwidget.cpp <span style="color: grey">(3bda22e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107822/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread] 