[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: Patch to re-enable vorbis-support in audiocd-kio
From:       Michael Pyne <mpyne () kde ! org>
Date:       2012-09-30 23:24:49
Message-ID: 3736598.047c0c7hTF () midna
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thursday, September 27, 2012 16:53:35 Felix Tiede wrote:
> Hello,
> 
> as per mpyne's request from https://bugs.kde.org/show_bug.cgi?id=307343#c4
> I propose my patch to audiocd-kio for review.

> I have removed all conditional compiling from
> the plugin in favor of this configure-time check as I doubt there is still
> an installation of libvorbisenc older than those ten years.

I think you've left this part of the patch out. ;)

> I am not sure which is the minimum version of cmake to create
> HAVE_LIBVORBISENC2 variable, my cmake is v2.8.9 and does so.

I've just checked and it seems that FindOggVorbis.cmake is actually part of 
kdelibs, not CMake. So we can be assured that a proper FindOggVorbis.cmake 
will be available.

Are there any issues with bumping the required version of libvorbis? Despite 
the name of the configure check I've been able to verify that just as Felix 
says, even very old releases of libvorbis provide the required interface.

Regards,
 - Michael Pyne
["signature.asc" (application/pgp-signature)]

_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


[prev in list] [next in list] [prev in thread] [next in thread]