From kde-multimedia  Sun Sep 30 23:24:49 2012
From: Michael Pyne <mpyne () kde ! org>
Date: Sun, 30 Sep 2012 23:24:49 +0000
To: kde-multimedia
Subject: Re: Patch to re-enable vorbis-support in audiocd-kio
Message-Id: <3736598.047c0c7hTF () midna>
X-MARC-Message: https://marc.info/?l=kde-multimedia&m=134904751405485
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============7991383391194648214=="


--===============7991383391194648214==
Content-Type: multipart/signed; boundary="nextPart1679559.GSJE6tpvyU"; micalg="pgp-sha256"; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7Bit


--nextPart1679559.GSJE6tpvyU
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Thursday, September 27, 2012 16:53:35 Felix Tiede wrote:
> Hello,
> 
> as per mpyne's request from https://bugs.kde.org/show_bug.cgi?id=307343#c4
> I propose my patch to audiocd-kio for review.

> I have removed all conditional compiling from
> the plugin in favor of this configure-time check as I doubt there is still
> an installation of libvorbisenc older than those ten years.

I think you've left this part of the patch out. ;)

> I am not sure which is the minimum version of cmake to create
> HAVE_LIBVORBISENC2 variable, my cmake is v2.8.9 and does so.

I've just checked and it seems that FindOggVorbis.cmake is actually part of 
kdelibs, not CMake. So we can be assured that a proper FindOggVorbis.cmake 
will be available.

Are there any issues with bumping the required version of libvorbis? Despite 
the name of the configure check I've been able to verify that just as Felix 
says, even very old releases of libvorbis provide the required interface.

Regards,
 - Michael Pyne
--nextPart1679559.GSJE6tpvyU
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQIcBAABCAAGBQJQaNTIAAoJEAuvDJx7auny13IQAJyEPfD4tn6NW/KkQKQ/sipK
19rBDBI+ZSJVo9/7J4v5efDIyOdz2ZLIQ7jbR8v7eMx7ROcOMqRhD8bSEe1TK1i+
qsUpztriIkMuWvoD2A2Q5Bhkt1LdKZfBSig7A0dic0HM2CBMi6kC3V5HmCoZAqmy
Y7NTqJ7SJ3GRi8fPb8gDCSeh3qSAwXRnoilaxv0Do0QRwfVlOwkV/zLh5gH+UJcL
iVX7s/l7hv0Ufrw+DsJpM3Juh9gTROKYloFWyKCJFhdaVF6MJC+M0lx0LBCNqBoe
P0Jv4TAsIjVC/OPIGGaCoWEjR/w16TAdYH51/nwFA9R83Xfc55PZxJAUCxpzJDDO
5XC4UQureCg4v3upFyGB+Pf5rPFWvy3Ka6AGiHRfnoNEVf1C/FzlJCRnGs3xH1w6
qvg8zCzQjq4Y5faBO1VKH//ezxvessjYLcluVmoMPvY8ufoByxBaxGh6A7TW65Qx
UdFQyLizbiRHvVqU/PZMmUl+muX05iYbMMOnr6tb+CTAtEL/ZzdEdjSKgiK5H0tD
52e53/nA6sTDm0hzXfr/ZryyUiranfp3JkghGl8A/ejwBoi2Wza18iLRr/+ijA1q
EtCCL5DNs7yyL9QPkowvTBf60xU2HOVg7V4t9oas8Y9xGIC8nwv9A8/dgLuzSjUj
kBaKAy0gfB+QIMeMd11I
=l1Xl
-----END PGP SIGNATURE-----

--nextPart1679559.GSJE6tpvyU--


--===============7991383391194648214==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia

--===============7991383391194648214==--