[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Disabling aRts in knotify
From:       Arnold Krille <kde () arnoldarts ! de>
Date:       2004-02-16 22:04:48
Message-ID: 200402162304.59314.kde () arnoldarts ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Hi all,

after getting a lot of rumors about knotify starting aRts if if aRts was 
disabled in KControl (Section "Sound system") I investigated a bit:

As it seems KNotify doesn't respect the setting in "Sound system". So I added 
another checkbox to the advanced playersettings to disable aRts. I didn't 
test wether aRts still gets started or not so far (I didn't want to stop my 
music :-) ) but It doesn't try to play sounds or connect to aRts anymore if 
told so.
This would be a short time solution with the possibility for backporting imho. 
But: It adds one completly new string ("Use the aRts sound system") and the 
name of the kcontrol-module for arts should be replaced since it isn't for 
all sound system but for aRts only and that one leads to obscurities for most 
users.

A long time solution I have in mind is: Make knotify's sound-abilities 
independent of aRts not just by providing an external player command but by 
implementing native playingcapabilities for Alsa, Jack, (esd, nas,etc) if 
that is easily implementable or (otherwise) provide "default player commands" 
for some other sound systems.

An even longer time solution (kde4) whould be a completly new soundsystem 
which is only a layer between kde and the actual sound-server or driver...

Attached is a patch for the short solution...

What do you guys (and girls) out there think about these three (or possibly) 
more solutions?

Please note: I don't want to start a discussion about advantages and 
disadvantages of various sound systems. This has been discussed enough and we 
don't find a good solution fast enough... [1]

And maybe someone could give me an "okay to commit" or "don't commit" for my 
patches...

Arnold

PS: The crossposting to kde-multimedia is intended...

[1] I you feel like discussing sound systems in general please let it happen 
on kde-multimedia...

-- 
Get my public-key from pgp.mit.edu or pgp.uni-mainz.de

["knotify_without_arts-kdebase.diff" (text/x-diff)]

Index: knotify.cpp
===================================================================
RCS file: /home/kde/kdebase/kcontrol/knotify/knotify.cpp,v
retrieving revision 1.71
diff -u -p -r1.71 knotify.cpp
--- knotify.cpp	5 Feb 2004 00:45:47 -0000	1.71
+++ knotify.cpp	16 Feb 2004 21:56:26 -0000
@@ -233,10 +233,14 @@ PlayerSettingsDialog::PlayerSettingsDial
     hbox->addWidget( volumeLabel );
     hbox->addWidget( volumeSlider );
 
+    cbUseArts = new QCheckBox( i18n( "Use the aRts Soundsystem" ), frame );
+    topLayout->addWidget( cbUseArts );
+
     load();
     dataChanged = false;
     enableButton(Apply, false);
     connect( cbExternal, SIGNAL( toggled( bool ) ), this, SLOT( slotChanged() ) );
+    connect( cbUseArts, SIGNAL( toggled( bool ) ), this, SLOT( slotChanged() ) );
     connect( volumeSlider, SIGNAL( valueChanged ( int ) ), this, SLOT( slotChanged() ) );
     connect( reqExternal, SIGNAL( textChanged( const QString& ) ), this, SLOT( slotChanged() ) );
 }
@@ -251,6 +255,8 @@ void PlayerSettingsDialog::load()
     reqExternal->setEnabled( cbExternal->isChecked() );
     volumeSlider->setValue( config.readNumEntry( "Volume", 100 ) );
     volumeSlider->parentWidget()->setEnabled( !cbExternal->isChecked() );
+    config.setGroup( "StartProgress" );
+    cbUseArts->setChecked( config.readBoolEntry( "Use Arts", true ) );
 }
 
 void PlayerSettingsDialog::save()
@@ -261,6 +267,8 @@ void PlayerSettingsDialog::save()
     config.writePathEntry( "External player", reqExternal->url() );
     config.writeEntry( "Use external player", cbExternal->isChecked() );
     config.writeEntry( "Volume", volumeSlider->value() );
+    config.setGroup( "StartProgress" );
+    config.writeEntry( "Use Arts", cbUseArts->isChecked() );
     config.sync();
 }
 
Index: knotify.h
===================================================================
RCS file: /home/kde/kdebase/kcontrol/knotify/knotify.h,v
retrieving revision 1.27
diff -u -p -r1.27 knotify.h
--- knotify.h	26 Jul 2003 10:41:20 -0000	1.27
+++ knotify.h	16 Feb 2004 21:56:26 -0000
@@ -90,7 +90,7 @@ protected slots:
     void slotChanged();
 
 private:
-    QCheckBox *cbExternal;
+    QCheckBox *cbExternal, *cbUseArts;
     KURLRequester *reqExternal;
     QSlider *volumeSlider;
     QLabel *volumeLabel;

[Attachment #8 (application/pgp-signature)]

_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


[prev in list] [next in list] [prev in thread] [next in thread]