From kde-multimedia Mon Feb 16 22:04:48 2004 From: Arnold Krille Date: Mon, 16 Feb 2004 22:04:48 +0000 To: kde-multimedia Subject: Disabling aRts in knotify Message-Id: <200402162304.59314.kde () arnoldarts ! de> X-MARC-Message: https://marc.info/?l=kde-multimedia&m=107696915703551 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1500090265==" --===============1500090265== Content-type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Boundary-03=_L6TMAym0yMP3SPm"; charset=iso-8859-15 Content-transfer-encoding: 7bit --Boundary-03=_L6TMAym0yMP3SPm Content-Type: multipart/mixed; boundary="Boundary-01=_A6TMABJiw45jGjk" Content-Transfer-Encoding: 7bit Content-Disposition: inline --Boundary-01=_A6TMABJiw45jGjk Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi all, after getting a lot of rumors about knotify starting aRts if if aRts was=20 disabled in KControl (Section "Sound system") I investigated a bit: As it seems KNotify doesn't respect the setting in "Sound system". So I add= ed=20 another checkbox to the advanced playersettings to disable aRts. I didn't=20 test wether aRts still gets started or not so far (I didn't want to stop my= =20 music :-) ) but It doesn't try to play sounds or connect to aRts anymore if= =20 told so. This would be a short time solution with the possibility for backporting im= ho.=20 But: It adds one completly new string ("Use the aRts sound system") and the= =20 name of the kcontrol-module for arts should be replaced since it isn't for= =20 all sound system but for aRts only and that one leads to obscurities for mo= st=20 users. A long time solution I have in mind is: Make knotify's sound-abilities=20 independent of aRts not just by providing an external player command but by= =20 implementing native playingcapabilities for Alsa, Jack, (esd, nas,etc) if=20 that is easily implementable or (otherwise) provide "default player command= s"=20 for some other sound systems. An even longer time solution (kde4) whould be a completly new soundsystem=20 which is only a layer between kde and the actual sound-server or driver... Attached is a patch for the short solution... What do you guys (and girls) out there think about these three (or possibly= )=20 more solutions? Please note: I don't want to start a discussion about advantages and=20 disadvantages of various sound systems. This has been discussed enough and = we=20 don't find a good solution fast enough... [1] And maybe someone could give me an "okay to commit" or "don't commit" for m= y=20 patches... Arnold PS: The crossposting to kde-multimedia is intended... [1] I you feel like discussing sound systems in general please let it happe= n=20 on kde-multimedia... =2D-=20 Get my public-key from pgp.mit.edu or pgp.uni-mainz.de --Boundary-01=_A6TMABJiw45jGjk Content-Type: text/x-diff; charset="iso-8859-15"; name="knotify_without_arts-kdebase.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="knotify_without_arts-kdebase.diff" Index: knotify.cpp =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/kde/kdebase/kcontrol/knotify/knotify.cpp,v retrieving revision 1.71 diff -u -p -r1.71 knotify.cpp =2D-- knotify.cpp 5 Feb 2004 00:45:47 -0000 1.71 +++ knotify.cpp 16 Feb 2004 21:56:26 -0000 @@ -233,10 +233,14 @@ PlayerSettingsDialog::PlayerSettingsDial hbox->addWidget( volumeLabel ); hbox->addWidget( volumeSlider ); =20 + cbUseArts =3D new QCheckBox( i18n( "Use the aRts Soundsystem" ), frame= ); + topLayout->addWidget( cbUseArts ); + load(); dataChanged =3D false; enableButton(Apply, false); connect( cbExternal, SIGNAL( toggled( bool ) ), this, SLOT( slotChange= d() ) ); + connect( cbUseArts, SIGNAL( toggled( bool ) ), this, SLOT( slotChanged= () ) ); connect( volumeSlider, SIGNAL( valueChanged ( int ) ), this, SLOT( slo= tChanged() ) ); connect( reqExternal, SIGNAL( textChanged( const QString& ) ), this, S= LOT( slotChanged() ) ); } @@ -251,6 +255,8 @@ void PlayerSettingsDialog::load() reqExternal->setEnabled( cbExternal->isChecked() ); volumeSlider->setValue( config.readNumEntry( "Volume", 100 ) ); volumeSlider->parentWidget()->setEnabled( !cbExternal->isChecked() ); + config.setGroup( "StartProgress" ); + cbUseArts->setChecked( config.readBoolEntry( "Use Arts", true ) ); } =20 void PlayerSettingsDialog::save() @@ -261,6 +267,8 @@ void PlayerSettingsDialog::save() config.writePathEntry( "External player", reqExternal->url() ); config.writeEntry( "Use external player", cbExternal->isChecked() ); config.writeEntry( "Volume", volumeSlider->value() ); + config.setGroup( "StartProgress" ); + config.writeEntry( "Use Arts", cbUseArts->isChecked() ); config.sync(); } =20 Index: knotify.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/kde/kdebase/kcontrol/knotify/knotify.h,v retrieving revision 1.27 diff -u -p -r1.27 knotify.h =2D-- knotify.h 26 Jul 2003 10:41:20 -0000 1.27 +++ knotify.h 16 Feb 2004 21:56:26 -0000 @@ -90,7 +90,7 @@ protected slots: void slotChanged(); =20 private: =2D QCheckBox *cbExternal; + QCheckBox *cbExternal, *cbUseArts; KURLRequester *reqExternal; QSlider *volumeSlider; QLabel *volumeLabel; --Boundary-01=_A6TMABJiw45jGjk-- --Boundary-03=_L6TMAym0yMP3SPm Content-Type: application/pgp-signature Content-Description: signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (GNU/Linux) iD8DBQBAMT6LuYLL1cDjHx0RAoQ8AJ9kBcLARQR1mbB3EW0YNsOWxxgiOACeIGIx wuACJMuJT4JMbQX+ojr1xf4= =W2ET -----END PGP SIGNATURE----- --Boundary-03=_L6TMAym0yMP3SPm-- --===============1500090265== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-multimedia mailing list kde-multimedia@kde.org https://mail.kde.org/mailman/listinfo/kde-multimedia --===============1500090265==--