[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: [PATCH] kcmaudiocd - Ogg Vorbis settings
From:       Jason Lane <jglane () btopenworld ! com>
Date:       2002-08-29 20:23:08
[Download RAW message or body]

Attached is an improved version of my patch -- addressing the points below. 

On Thursday 29 August 2002 1:09 pm, Ryan Cumming wrote:
> 1) Having widgets disappear and reappear based on other widgets is
> generally considered bad form. It'd be better if both groups were always
> displayed, but appropriately disabled. I'll look in to fixing the MP3 tab
> to do the same.
I was following the 'example' of the MP3 tab... but now fixed. The hide() and 
show() calls changed to setEnabled(). I also took the liberty of changing the 
hide()/show() calls for the MP3 tab, too, for consistency. It does have the 
side effect of making the dialogue require a scroll bar on an 800x600 
display, though.

> 2) As per the styleguide, radiobuttons should use sentence-style
> capitalization, not title.
A subtle thing to overlook... fixed.

> 3) Yes, we're in a feature freeze, but if the UI issues are cleaned up, it
> seems small enough to fit in.
:-)

Thanks for spending the time to have a look at my patch. Cheers,

Jason

["vorbis-kcmaudiocd.patch.bz2" (application/x-bzip2)]
_______________________________________________
kde-multimedia mailing list
kde-multimedia@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread]