[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: [PATCH] kcmaudiocd - Ogg Vorbis settings
From:       Ryan Cumming <ryan () completely ! kicks-ass ! org>
Date:       2002-08-29 13:09:17
[Download RAW message or body]

On August 28, 2002 17:06, Jason Lane wrote:
Hi,

> I don't have CVS access, so if it's useful and I've not introduced any new
> bugs into kcmaudiocd, or broken any feature freezes, then feel free to
> commit it. It should work for Vorbis RC3+ and by selecting the bitrate
> option only, should work for earlier versions of Vorbis, too

1) Having widgets disappear and reappear based on other widgets is generally 
considered bad form. It'd be better if both groups were always displayed, but 
appropriately disabled. I'll look in to fixing the MP3 tab to do the same.

2) As per the styleguide, radiobuttons should use sentence-style 
capitalization, not title.

3) Yes, we're in a feature freeze, but if the UI issues are cleaned up, it 
seems small enough to fit in.

-Ryan
_______________________________________________
kde-multimedia mailing list
kde-multimedia@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-multimedia
[prev in list] [next in list] [prev in thread] [next in thread]