[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Inconsistency using proxy in kscd
From:       Michael Goffioul <goffioul () imec ! be>
Date:       2002-06-10 12:43:07
[Download RAW message or body]

I had a problem using proxy (for CDDB) in kscd: each time I restarted
kscd, the check box "Use HTTP Proxy to access...." was deselected,
even if I selected it in the previous run of kscd.

I'm using an auto-proxy script, and this is part of the reason why
kscd always reset "CDDDBHtttpProxyEnabled" to false at startup.
In kscd.cpp, it first gets the value from the config file (which is
then true). Afterwards, if checks the default proxy settings using

KProtocolManager::proxyFor( "http" )

The problem is that function doesn't take into account auto-proxy
script, and simply looks for "<protocol>Proxy" entry in the file
kioslaverc. In my case, all those entries are empty as I'm using
a proxy script. As the string returned is empty, kscd reset the
"use-proxy" setting to false, loosing the value that was actually
saved in the config file.

The easy fix is the one attached, but I'm not sure if this is the
right way to do it. Basically, shouldn't the function
KProtocolManager::proxyFor() also make use of an auto-proxy script
in some way?

Bye.
Michael.

-- 
------------------------------------------------------------------
Michael Goffioul		IMEC-DESICS-MIRA
e-mail: goffioul@imec.be	(Mixed-Signal and RF Applications)
Tel:    +32/16/28-8510		Kapeldreef, 75
Fax:    +32/16/28-1515		3001 HEVERLEE, BELGIUM
------------------------------------------------------------------
["kscd.diff" (text/plain)]

Index: kscd.cpp
===================================================================
RCS file: /home/kde/kdemultimedia/kscd/kscd.cpp,v
retrieving revision 1.154
diff -u -3 -p -r1.154 kscd.cpp
--- kscd.cpp	2002/04/20 13:01:01	1.154
+++ kscd.cpp	2002/06/10 12:31:59
@@ -1744,7 +1744,7 @@ KSCD::readSettings()
       } else {
   proxyHost = "";
   proxyPort = 0;
-  cddb.useHTTPProxy(false);
+  //cddb.useHTTPProxy(false);
       }
     cddb.setHTTPProxy(config->readEntry("HTTPProxyHost",proxyHost),
                       config->readNumEntry("HTTPProxyPort",proxyPort));

_______________________________________________
kde-multimedia mailing list
kde-multimedia@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread]