[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-mac
Subject: Re: Review Request 129363: reliability fixes (WIP)
From: Yichao Yu <yyc1992 () gmail ! com>
Date: 2016-11-28 16:50:33
Message-ID: 20161128165033.20698.24894 () mimi ! kde ! org
[Download RAW message or body]
--===============4492420489496295830==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129363/#review101159
-----------------------------------------------------------
I still see (WIP) in the title. Do you want to make more changes in this \
one or do you want to do that in another one?
- Yichao Yu
On 十一月 8, 2016, 1:56 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129363/
> -----------------------------------------------------------
>
> (Updated 十一月 8, 2016, 1:56 p.m.)
>
>
> Review request for KDE Software on Mac OS X and Yichao Yu.
>
>
> Repository: qtcurve
>
>
> Description
> -------
>
> I've been making a number of fixes to QtCurve recently, mostly to improve \
> the reliability of its settings management. The current set of fixes is \
> getting a bit complex and thus something I'd rather put up for review \
> while I work on it.
> The leitmotiv is: read and write all settings all the time, even if you \
> don't use everything. This prevents settings getting lost.
> This approach is all the more important since I've restored the support \
> for a system-wide stylerc file. For now that's a MacPorts patch, but I'd \
> be happy to include it here if it's considered of general use.
>
> Diffs
> -----
>
> .reviewboardrc PRE-CREATION
> qt4/common/config_file.cpp 7a0a6bc
> qt4/config/qtcurveconfig.cpp 740150f
> qt4/style/qtcurve.cpp 5447e07
> qt5/common/config_file.cpp 7630f4e
> qt5/config/qtcurveconfig.cpp df8ce89
> qt5/style/qtcurve.cpp 4457def
>
> Diff: https://git.reviewboard.kde.org/r/129363/diff/
>
>
> Testing
> -------
>
> Being tested on Mac and Linux with QtCurve the main style.
>
>
> Thanks,
>
> René J.V. Bertin
>
>
--===============4492420489496295830==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129363/">https://git.reviewboard.kde.org/r/129363/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I still see (WIP) in the \
title. Do you want to make more changes in this one or do you want to do \
that in another one?</p></pre> <br />
<p>- Yichao Yu</p>
<br />
<p>On 十一月 8th, 2016, 1:56 p.m. EST, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X and Yichao Yu.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated 十一月 8, 2016, 1:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
qtcurve
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I've been making a number of \
fixes to QtCurve recently, mostly to improve the reliability of its \
settings management. The current set of fixes is getting a bit complex and \
thus something I'd rather put up for review while I work on it.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The leitmotiv is: read and write all \
settings all the time, even if you don't use everything. This prevents \
settings getting lost.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This approach \
is all the more important since I've restored the support for a system-wide \
stylerc file. For now that's a MacPorts patch, but I'd be happy to include \
it here if it's considered of general use.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Being tested on Mac and Linux \
with QtCurve the main style.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>.reviewboardrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>qt4/common/config_file.cpp <span style="color: \
grey">(7a0a6bc)</span></li>
<li>qt4/config/qtcurveconfig.cpp <span style="color: \
grey">(740150f)</span></li>
<li>qt4/style/qtcurve.cpp <span style="color: grey">(5447e07)</span></li>
<li>qt5/common/config_file.cpp <span style="color: \
grey">(7630f4e)</span></li>
<li>qt5/config/qtcurveconfig.cpp <span style="color: \
grey">(df8ce89)</span></li>
<li>qt5/style/qtcurve.cpp <span style="color: grey">(4457def)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129363/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4492420489496295830==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic