--===============4492420489496295830== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129363/#review101159 ----------------------------------------------------------- I still see (WIP) in the title. Do you want to make more changes in this one or do you want to do that in another one? - Yichao Yu On 十一月 8, 2016, 1:56 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129363/ > ----------------------------------------------------------- > > (Updated 十一月 8, 2016, 1:56 p.m.) > > > Review request for KDE Software on Mac OS X and Yichao Yu. > > > Repository: qtcurve > > > Description > ------- > > I've been making a number of fixes to QtCurve recently, mostly to improve the reliability of its settings management. The current set of fixes is getting a bit complex and thus something I'd rather put up for review while I work on it. > > The leitmotiv is: read and write all settings all the time, even if you don't use everything. This prevents settings getting lost. > > This approach is all the more important since I've restored the support for a system-wide stylerc file. For now that's a MacPorts patch, but I'd be happy to include it here if it's considered of general use. > > > Diffs > ----- > > .reviewboardrc PRE-CREATION > qt4/common/config_file.cpp 7a0a6bc > qt4/config/qtcurveconfig.cpp 740150f > qt4/style/qtcurve.cpp 5447e07 > qt5/common/config_file.cpp 7630f4e > qt5/config/qtcurveconfig.cpp df8ce89 > qt5/style/qtcurve.cpp 4457def > > Diff: https://git.reviewboard.kde.org/r/129363/diff/ > > > Testing > ------- > > Being tested on Mac and Linux with QtCurve the main style. > > > Thanks, > > René J.V. Bertin > > --===============4492420489496295830== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129363/ 

I still see (WIP) in the title. Do you want to make more changes in this one or do you want to do that in another one?

- Yichao Yu


On 十一月 8th, 2016, 1:56 p.m. EST, René J.V. Bertin wrote:

Review request for KDE Software on Mac OS X and Yichao Yu.
By René J.V. Bertin.

Updated 十一月 8, 2016, 1:56 p.m.

Repository: qtcurve

Description 

I've been making a number of fixes to QtCurve recently, mostly to improve the reliability of its settings management. The current set of fixes is getting a bit complex and thus something I'd rather put up for review while I work on it.


The leitmotiv is: read and write all settings all the time, even if you don't use everything. This prevents settings getting lost.


This approach is all the more important since I've restored the support for a system-wide stylerc file. For now that's a MacPorts patch, but I'd be happy to include it here if it's considered of general use.

Testing 

Being tested on Mac and Linux with QtCurve the main style.

Diffs

  • .reviewboardrc (PRE-CREATION)
  • qt4/common/config_file.cpp (7a0a6bc)
  • qt4/config/qtcurveconfig.cpp (740150f)
  • qt4/style/qtcurve.cpp (5447e07)
  • qt5/common/config_file.cpp (7630f4e)
  • qt5/config/qtcurveconfig.cpp (df8ce89)
  • qt5/style/qtcurve.cpp (4457def)

View Diff
--===============4492420489496295830==--