'Re: [KDE/Mac] Review Request 127896: make dbus optional on osx: kauth'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-mac
Subject:    Re: [KDE/Mac] Review Request 127896: make dbus optional on osx: kauth
From:       Nick Shaforostoff <shafff () ukr ! net>
Date:       2016-05-20 21:13:23
Message-ID: 20160520211323.15344.31018 () mimi ! kde ! org
[Download RAW message or body]

--===============4023485515270165831==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127896/
-----------------------------------------------------------

(Updated May 20, 2016, 9:13 p.m.)

Review request for KDE Software on Mac OS X, KDE Frameworks, David Edmundson, and Martin Gräßlin.

Changes
-------

made dbus enabling/disabling be available via cmake config option only, as asked

Repository: kauth

Description
-------

this is the first patch to make kde frameworks build (and then work) without dbus.

this will allow homebrew users use precompiled vanilla Qt to build kde apps on osx. as dbus is not a \
common service in osx world, kde apps on osx should use native means for interprocess communication \
instead -- this will make them better citizens in osx ecosystem.

Diffs (updated)
-----

  CMakeLists.txt 48dc2d9 
  autotests/BackendsManager.cpp 59675b3 
  autotests/CMakeLists.txt b53d760 
  autotests/HelperTest.cpp 8050a06 
  src/CMakeLists.txt 1b6930d 
  src/ConfigureChecks.cmake d46761a 

Diff: https://git.reviewboard.kde.org/r/127896/diff/

Testing
-------

compiles fine on osx, compiles fine on linux, tests on linux still pass.

Thanks,

Nick Shaforostoff

--===============4023485515270165831==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127896/">https://git.reviewboard.kde.org/r/127896/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Software on Mac OS X, KDE Frameworks, David Edmundson, and Martin \
Gräßlin.</div> <div>By Nick Shaforostoff.</div>

<p style="color: grey;"><i>Updated May 20, 2016, 9:13 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">made dbus enabling/disabling be available \
via cmake config option only, as asked</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kauth
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">this is the first patch to make kde \
frameworks build (and then work) without dbus.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">this will allow homebrew users use precompiled vanilla Qt \
to build kde apps on osx. as dbus is not a common service in osx world, kde apps on osx should use native \
means for interprocess communication instead -- this will make them better citizens in osx \
ecosystem.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">compiles fine on osx, compiles fine on \
linux, tests on linux still pass.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(48dc2d9)</span></li>

 <li>autotests/BackendsManager.cpp <span style="color: grey">(59675b3)</span></li>

 <li>autotests/CMakeLists.txt <span style="color: grey">(b53d760)</span></li>

 <li>autotests/HelperTest.cpp <span style="color: grey">(8050a06)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(1b6930d)</span></li>

 <li>src/ConfigureChecks.cmake <span style="color: grey">(d46761a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127896/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4023485515270165831==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-mac@kde.org
List Information: https://mail.kde.org/mailman/listinfo/kde-mac
KDE/Mac Information: http://community.kde.org/Mac

[prev in list] [next in list] [prev in thread] [next in thread] 