From kde-mac Fri May 20 21:13:23 2016 From: Nick Shaforostoff Date: Fri, 20 May 2016 21:13:23 +0000 To: kde-mac Subject: Re: [KDE/Mac] Review Request 127896: make dbus optional on osx: kauth Message-Id: <20160520211323.15344.31018 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-mac&m=146377883009562 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8164138201843823178==" --===============8164138201843823178== Content-Type: multipart/alternative; boundary="===============4023485515270165831==" --===============4023485515270165831== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127896/ ----------------------------------------------------------- (Updated May 20, 2016, 9:13 p.m.) Review request for KDE Software on Mac OS X, KDE Frameworks, David Edmundson, and Martin Gräßlin. Changes ------- made dbus enabling/disabling be available via cmake config option only, as asked Repository: kauth Description ------- this is the first patch to make kde frameworks build (and then work) without dbus. this will allow homebrew users use precompiled vanilla Qt to build kde apps on osx. as dbus is not a common service in osx world, kde apps on osx should use native means for interprocess communication instead -- this will make them better citizens in osx ecosystem. Diffs (updated) ----- CMakeLists.txt 48dc2d9 autotests/BackendsManager.cpp 59675b3 autotests/CMakeLists.txt b53d760 autotests/HelperTest.cpp 8050a06 src/CMakeLists.txt 1b6930d src/ConfigureChecks.cmake d46761a Diff: https://git.reviewboard.kde.org/r/127896/diff/ Testing ------- compiles fine on osx, compiles fine on linux, tests on linux still pass. Thanks, Nick Shaforostoff --===============4023485515270165831== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127896/

Review request for KDE Software on Mac OS X, KDE Frameworks, David Edmundson, and Martin Gräßlin.
By Nick Shaforostoff.

Updated May 20, 2016, 9:13 p.m.

Changes

made dbus enabling/disabling be available via cmake config option only, as asked
Repository: kauth

Description 

this is the first patch to make kde frameworks build (and then work) without dbus.


this will allow homebrew users use precompiled vanilla Qt to build kde apps on osx. as dbus is not a common service in osx world, kde apps on osx should use native means for interprocess communication instead -- this will make them better citizens in osx ecosystem.

Testing 

compiles fine on osx, compiles fine on linux, tests on linux still pass.

Diffs (updated)

  • CMakeLists.txt (48dc2d9)
  • autotests/BackendsManager.cpp (59675b3)
  • autotests/CMakeLists.txt (b53d760)
  • autotests/HelperTest.cpp (8050a06)
  • src/CMakeLists.txt (1b6930d)
  • src/ConfigureChecks.cmake (d46761a)

View Diff
--===============4023485515270165831==-- --===============8164138201843823178== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka2RlLW1hY0Br ZGUub3JnCkxpc3QgSW5mb3JtYXRpb246IGh0dHBzOi8vbWFpbC5rZGUub3JnL21haWxtYW4vbGlz dGluZm8va2RlLW1hYwpLREUvTWFjIEluZm9ybWF0aW9uOiBodHRwOi8vY29tbXVuaXR5LmtkZS5v cmcvTWFj --===============8164138201843823178==--