[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Refactoring D&D/Paste As feature for 5.1
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2022-01-04 10:30:35
Message-ID: CAEkBSfW01fAZhVEsyztDVW-BRe7sPuZ7KUm-JpMW040PWnw4Yg () mail ! gmail ! com
[Download RAW message or body]

Hi, amyspark!

We have never discussed that before. As far as I can tell, the requirements
for the new system should be something like this:

1) All mimedata handling routines should use common code (or at least
common policy/priorities)
    * D&D into the start page
    * D&D into KisView (that is, to an opened document)
    * D&D into Layers Docker
    * Paste from the clipboard
2) If mimetype has multiple formats, then they should be tried in the order
of (user customizable?) priority
    * all places should use the same priority (now the code is ad-hoc, so
the requirement is not fulfilled)
    * if one format exists, but fails, Krita should add warning to the log
and continue to a different format (now it stops on the first found
supported format)
3) The tests for D&D should be done for the matrix of configurations on
Chrome/Firefox/Safari versus Windows/Linux/MacOS. The same browser provides
different mimedata on different platforms


On Thu, Dec 30, 2021 at 1:53 AM L. E. Segovia <amy@amyspark.me> wrote:

> Hi all,
>
> I've previously submitted MR
> https://invent.kde.org/graphics/krita/-/merge_requests/1177/ to
> implement a consent flow for paste/drag-n-drop events that include an
> image URL.
>
> It's been marked as Needs Changes because we need a bigger refactor, the
> implementation is currently sprawled across five different classes, with
> potentially duplicate (or at the very least inconsistent) behaviour.
>
> Has this been discussed before? When could we set some time to check it
> out?
>
> Best,
>
> amyspark
>
> --
> amyspark 🌸 https://www.amyspark.me
>


-- 
Dmitry Kazakov

[Attachment #3 (text/html)]

<div dir="ltr">Hi, amyspark!<div><br></div><div>We have never discussed that before. \
As far as I can tell, the requirements for the new system should be something like \
this:</div><div><br></div><div>1) All mimedata handling routines should use common \
code (or at least common policy/priorities)</div><div>      * D&amp;D into the start \
page</div><div>      * D&amp;D into KisView (that is, to an opened \
document)</div><div>      * D&amp;D into Layers Docker</div><div>      * Paste from \
the clipboard</div><div>2) If mimetype has multiple formats, then they should be \
tried in the order of (user customizable?) priority</div><div>      * all places \
should use the same priority (now the code is ad-hoc, so the requirement is not \
fulfilled)</div><div>      * if one format exists, but fails, Krita should add \
warning to the log and continue to a different format (now it stops on the first \
found supported format)</div><div>3) The tests for D&amp;D should be done for the \
matrix of configurations on Chrome/Firefox/Safari versus Windows/Linux/MacOS. The \
same browser provides different mimedata on different \
platforms</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Thu, Dec 30, 2021 at 1:53 AM L. E. Segovia &lt;<a \
href="mailto:amy@amyspark.me" target="_blank">amy@amyspark.me</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi all,<br> <br>
I&#39;ve previously submitted MR <br>
<a href="https://invent.kde.org/graphics/krita/-/merge_requests/1177/" \
rel="noreferrer" target="_blank">https://invent.kde.org/graphics/krita/-/merge_requests/1177/</a> \
to <br> implement a consent flow for paste/drag-n-drop events that include an <br>
image URL.<br>
<br>
It&#39;s been marked as Needs Changes because we need a bigger refactor, the <br>
implementation is currently sprawled across five different classes, with <br>
potentially duplicate (or at the very least inconsistent) behaviour.<br>
<br>
Has this been discussed before? When could we set some time to check it out?<br>
<br>
Best,<br>
<br>
amyspark<br>
<br>
-- <br>
amyspark 🌸 <a href="https://www.amyspark.me" rel="noreferrer" \
target="_blank">https://www.amyspark.me</a><br> </blockquote></div><br \
clear="all"><div><br></div>-- <br><div dir="ltr">Dmitry Kazakov</div>



[prev in list] [next in list] [prev in thread] [next in thread]