[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: String Freeze for Krita 5
From: Dmitry Kazakov <dimula73 () gmail ! com>
Date: 2021-11-13 11:25:54
Message-ID: CAEkBSfVDSHyomOCL1QA1yVoSG=HDyxJpF8y8TVr2uWkrmTpt4w () mail ! gmail ! com
[Download RAW message or body]
Hi, all!
I have just merged a patchset that add 7 new strings into both krita-stable
and krita-master. These strings were necessary, because they notify the
user that his/her saved .kra file is potentially incomplete or corrupted.
Here is the list of new strings:
# void KisDocument::slotCompleteSavingDocument
+ DlgLoadMessages dlg(i18nc("@title:window", "Krita"),
+ i18nc("dialog box shown to the user if
there were warnings while saving the document, %1 is the file path",
+ "%1 has been saved but is
incomplete.\nThe following problems were encountered when saving:",
job.filePath),
+ warningMessage.split("\n"));
# KisKraLoader::loadResources
+ m_d->warningMessages.append(i18nc("Warning message on loading a .kra
file", "Embedded resource cannot be read. The filename of the resource:
%1", resourceItem.filename));
+ m_d->warningMessages.append(i18nc("Warning message on loading a .kra
file", "Embedded resource cannot be imported. The filename of the resource:
%1", resourceItem.filename));
# KisKraSaver::saveResources
+ m_d->warningMessages << i18nc("Error message when saving a .kra file",
"Could not export resource for embedding: %1", result.signature().filename);
+ m_d->warningMessages << i18nc("Error message when saving a .kra file",
"Could not write resource: %1", result.signature().filename);
+ m_d->warningMessages << i18nc("Error message when saving a .kra file",
"Written resource is empty: %1", result.signature().filename);
+ m_d->warningMessages << i18nc("Error message when saving a .kra file",
"Written resource is incomplete: %1. ", result.signature().filename);
On Wed, Jul 14, 2021 at 11:10 PM Luigi Toscano <luigi.toscano@tiscali.it>
wrote:
> Alvin Wong ha scritto:
> > Hi Luigi,
> >
> > I don't oppose to the idea of split these messages into a separate
> catalog,
> > but I am not familiar enough with the i18n infrastructure to know what
> effects
> > it will have and what changes will need to be implemented. Can you
> please give
> > a bit of detail?
>
> You would need a different Messages.sh file just to extract those messages,
> and tune the original Messages.sh to ignore them. The complicated part
> would
> be on the code side, as you would need to use the variant of the i18n*
> calls
> which allows you to set the message catalog.
>
>
> > Another thing to note is that, although most of the relevant messages
> are new,
> > there are 68 of them that has been translatable for some time. If we
> want to
> > split these messages into their own catalog, ideally we should have them
> > copied over from the existing translated krita.po catalogs.
>
> That could be done the first time (or just leave that to the teams.)
>
> --
> Luigi
>
--
Dmitry Kazakov
[Attachment #3 (text/html)]
<div dir="ltr">Hi, all!<div><br></div><div>I have just merged a patchset that add 7 \
new strings into both krita-stable and krita-master. These strings were necessary, \
because they notify the user that his/her saved .kra file is potentially incomplete \
or corrupted. Here is the list of new strings:</div><div><br></div><div># void \
KisDocument::slotCompleteSavingDocument<br><br>+ DlgLoadMessages \
dlg(i18nc("@title:window", "Krita"),<br><a \
class="gmail_plusreply" id="plusReplyChip-0">+</a> \
i18nc("dialog box shown to the user if there were warnings while saving the \
document, %1 is the file path",<br><a class="gmail_plusreply" \
id="plusReplyChip-1">+</a> \
"%1 has been saved but is incomplete.\nThe following problems were encountered \
when saving:", job.filePath),<br>+ \
warningMessage.split("\n"));<br><br><br># \
KisKraLoader::loadResources<br><br>+ \
m_d->warningMessages.append(i18nc("Warning message on loading a .kra \
file", "Embedded resource cannot be read. The filename of the resource: \
%1", resourceItem.filename));<br>+ \
m_d->warningMessages.append(i18nc("Warning message on loading a .kra \
file", "Embedded resource cannot be imported. The filename of the resource: \
%1", resourceItem.filename));<br><br># KisKraSaver::saveResources<br><br>+ \
m_d->warningMessages << i18nc("Error message when saving a .kra \
file", "Could not export resource for embedding: %1", \
result.signature().filename);<br>+ m_d->warningMessages << i18nc("Error \
message when saving a .kra file", "Could not write resource: %1", \
result.signature().filename);<br>+ m_d->warningMessages << i18nc("Error \
message when saving a .kra file", "Written resource is empty: %1", \
result.signature().filename);<br>+ m_d->warningMessages << i18nc("Error \
message when saving a .kra file", "Written resource is incomplete: %1. \
", result.signature().filename);<br></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jul 14, 2021 at 11:10 \
PM Luigi Toscano <<a \
href="mailto:luigi.toscano@tiscali.it">luigi.toscano@tiscali.it</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Alvin Wong ha \
scritto:<br> > Hi Luigi,<br>
> <br>
> I don't oppose to the idea of split these messages into a separate \
catalog,<br> > but I am not familiar enough with the i18n infrastructure to know \
what effects<br> > it will have and what changes will need to be implemented. Can \
you please give<br> > a bit of detail?<br>
<br>
You would need a different Messages.sh file just to extract those messages,<br>
and tune the original Messages.sh to ignore them. The complicated part would<br>
be on the code side, as you would need to use the variant of the i18n* calls<br>
which allows you to set the message catalog.<br>
<br>
<br>
> Another thing to note is that, although most of the relevant messages are \
new,<br> > there are 68 of them that has been translatable for some time. If we \
want to<br> > split these messages into their own catalog, ideally we should have \
them<br> > copied over from the existing translated krita.po catalogs.<br>
<br>
That could be done the first time (or just leave that to the teams.)<br>
<br>
-- <br>
Luigi<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" \
class="gmail_signature">Dmitry Kazakov</div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic