Hi, all!

I have just merged a patchset that add 7 new strings into both krita-stable and krita-master. These strings were necessary, because they notify the user that his/her saved .kra file is potentially incomplete or corrupted. Here is the list of new strings:

# void KisDocument::slotCompleteSavingDocument

+ DlgLoadMessages dlg(i18nc("@title:window", "Krita"),
+                                i18nc("dialog box shown to the user if there were warnings while saving the document, %1 is the file path",
+                                     "%1 has been saved but is incomplete.\nThe following problems were encountered when saving:", job.filePath),
+                               warningMessage.split("\n"));


# KisKraLoader::loadResources

+ m_d->warningMessages.append(i18nc("Warning message on loading a .kra file", "Embedded resource cannot be read. The filename of the resource: %1", resourceItem.filename));
+ m_d->warningMessages.append(i18nc("Warning message on loading a .kra file", "Embedded resource cannot be imported. The filename of the resource: %1", resourceItem.filename));

# KisKraSaver::saveResources

+ m_d->warningMessages << i18nc("Error message when saving a .kra file", "Could not export resource for embedding: %1", result.signature().filename);
+ m_d->warningMessages << i18nc("Error message when saving a .kra file", "Could not write resource: %1", result.signature().filename);
+ m_d->warningMessages << i18nc("Error message when saving a .kra file", "Written resource is empty: %1", result.signature().filename);
+ m_d->warningMessages << i18nc("Error message when saving a .kra file", "Written resource is incomplete: %1. ", result.signature().filename);

On Wed, Jul 14, 2021 at 11:10 PM Luigi Toscano <luigi.toscano@tiscali.it> wrote:
Alvin Wong ha scritto:
> Hi Luigi,
>
> I don't oppose to the idea of split these messages into a separate catalog,
> but I am not familiar enough with the i18n infrastructure to know what effects
> it will have and what changes will need to be implemented. Can you please give
> a bit of detail?

You would need a different Messages.sh file just to extract those messages,
and tune the original Messages.sh to ignore them. The complicated part would
be on the code side, as you would need to use the variant of the i18n* calls
which allows you to set the message catalog.


> Another thing to note is that, although most of the relevant messages are new,
> there are 68 of them that has been translatable for some time. If we want to
> split these messages into their own catalog, ideally we should have them
> copied over from the existing translated krita.po catalogs.

That could be done the first time (or just leave that to the teams.)

--
Luigi


--
Dmitry Kazakov