[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: Histogram and channels branch needs testers
From: Dmitry Kazakov <dimula73 () gmail ! com>
Date: 2016-07-26 11:54:42
Message-ID: CAEkBSfX=4jwvmFMPiVajhSJDB3M3mmoSq13Z6OoaZJfHg8hGVA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
For me the branch looks also good :)
The only thing I don't really like is the styling change in some methods of
KisPaintDevice you didn't actually modify. I still prefere the
brace-on-the-seme-line style for inline methods. But that is extremely
disputable and cannot be a blocker for a merge :)
On Tue, Jul 26, 2016 at 10:58 AM, Boudewijn Rempt <boud@valdyas.org> wrote:
> I tested the branch today, and I think it's good to go!
>
> On Mon, 25 Jul 2016, EI wrote:
>
> > If you build from source and would like to help with a bit of testing, my
> > branch
> >
> >
> https://phabricator.kde.org/diffusion/KRITA/browse/thumbnail_improvements/
> >
> > is ready for wider testing. It adds histogram docker and a bit of "eye
> > candy":
> >
> > 1. New histogram docker shows current image histogram. It can be enabled
> > from
> >
> > 2. Channel docker shows thumbnails of each color channel. You can use
> > checkmarks to enable/disable different color channels (but not alpha
> > channel). Double click on a channel row should disable all other color
> > channels.
> >
> > 3. Overview docker now has higher quality thumbnail (anti-aliased).
> >
> > 4. All three dockers update with a slight delay (~1/4 sec) after you stop
> > painting to avoid interrupting paint operations.
> >
> > When testing please look for new slowdowns when painting, memory leaks,
> > inconsistent behavior, etc.
> >
> > Thank you,
> > Eugene
> >
>
> --
> Boudewijn Rempt | http://www.krita.org, http://www.valdyas.org
> _______________________________________________
> Krita mailing list
> kimageshop@kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
>
--
Dmitry Kazakov
[Attachment #5 (text/html)]
<div dir="ltr"><div>For me the branch looks also good :)<br><br></div>The only thing \
I don't really like is the styling change in some methods of KisPaintDevice you \
didn't actually modify. I still prefere the brace-on-the-seme-line style for \
inline methods. But that is extremely disputable and cannot be a blocker for a merge \
:)<br><div><br><br></div></div><div class="gmail_extra"><br><div \
class="gmail_quote">On Tue, Jul 26, 2016 at 10:58 AM, Boudewijn Rempt <span \
dir="ltr"><<a href="mailto:boud@valdyas.org" \
target="_blank">boud@valdyas.org</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">I tested the branch today, and I think it's good to \
go!<br> <div class="HOEnZb"><div class="h5"><br>
On Mon, 25 Jul 2016, EI wrote:<br>
<br>
> If you build from source and would like to help with a bit of testing, my<br>
> branch<br>
><br>
> <a href="https://phabricator.kde.org/diffusion/KRITA/browse/thumbnail_improvements/" \
rel="noreferrer" target="_blank">https://phabricator.kde.org/diffusion/KRITA/browse/thumbnail_improvements/</a><br>
><br>
> is ready for wider testing. It adds histogram docker and a bit of "eye<br>
> candy":<br>
><br>
> 1. New histogram docker shows current image histogram. It can be enabled<br>
> from<br>
><br>
> 2. Channel docker shows thumbnails of each color channel. You can use<br>
> checkmarks to enable/disable different color channels (but not alpha<br>
> channel). Double click on a channel row should disable all other color<br>
> channels.<br>
><br>
> 3. Overview docker now has higher quality thumbnail (anti-aliased).<br>
><br>
> 4. All three dockers update with a slight delay (~1/4 sec) after you stop<br>
> painting to avoid interrupting paint operations.<br>
><br>
> When testing please look for new slowdowns when painting, memory leaks,<br>
> inconsistent behavior, etc.<br>
><br>
> Thank you,<br>
> Eugene<br>
><br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Boudewijn Rempt | <a href="http://www.krita.org" rel="noreferrer" \
target="_blank">http://www.krita.org</a>, <a href="http://www.valdyas.org" \
rel="noreferrer" target="_blank">http://www.valdyas.org</a><br> \
_______________________________________________<br> Krita mailing list<br>
<a href="mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kimageshop" rel="noreferrer" \
target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br> \
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div \
class="gmail_signature" data-smartmail="gmail_signature">Dmitry Kazakov</div> </div>
[Attachment #6 (text/plain)]
_______________________________________________
Krita mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic