From kde-kimageshop Tue Jul 26 11:54:42 2016 From: Dmitry Kazakov Date: Tue, 26 Jul 2016 11:54:42 +0000 To: kde-kimageshop Subject: Re: Histogram and channels branch needs testers Message-Id: X-MARC-Message: https://marc.info/?l=kde-kimageshop&m=146953409615707 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3161405109340048294==" --===============3161405109340048294== Content-Type: multipart/alternative; boundary=001a114bddfe0248ad05388891f3 --001a114bddfe0248ad05388891f3 Content-Type: text/plain; charset=UTF-8 For me the branch looks also good :) The only thing I don't really like is the styling change in some methods of KisPaintDevice you didn't actually modify. I still prefere the brace-on-the-seme-line style for inline methods. But that is extremely disputable and cannot be a blocker for a merge :) On Tue, Jul 26, 2016 at 10:58 AM, Boudewijn Rempt wrote: > I tested the branch today, and I think it's good to go! > > On Mon, 25 Jul 2016, EI wrote: > > > If you build from source and would like to help with a bit of testing, my > > branch > > > > > https://phabricator.kde.org/diffusion/KRITA/browse/thumbnail_improvements/ > > > > is ready for wider testing. It adds histogram docker and a bit of "eye > > candy": > > > > 1. New histogram docker shows current image histogram. It can be enabled > > from > > > > 2. Channel docker shows thumbnails of each color channel. You can use > > checkmarks to enable/disable different color channels (but not alpha > > channel). Double click on a channel row should disable all other color > > channels. > > > > 3. Overview docker now has higher quality thumbnail (anti-aliased). > > > > 4. All three dockers update with a slight delay (~1/4 sec) after you stop > > painting to avoid interrupting paint operations. > > > > When testing please look for new slowdowns when painting, memory leaks, > > inconsistent behavior, etc. > > > > Thank you, > > Eugene > > > > -- > Boudewijn Rempt | http://www.krita.org, http://www.valdyas.org > _______________________________________________ > Krita mailing list > kimageshop@kde.org > https://mail.kde.org/mailman/listinfo/kimageshop > -- Dmitry Kazakov --001a114bddfe0248ad05388891f3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
For me the branch looks also good :)

The= only thing I don't really like is the styling change in some methods o= f KisPaintDevice you didn't actually modify. I still prefere the brace-= on-the-seme-line style for inline methods. But that is extremely disputable= and cannot be a blocker for a merge :)



On Tue, Jul 26, 2016 at = 10:58 AM, Boudewijn Rempt <boud@valdyas.org> wrote:
I tested the branch today, and I think it's go= od to go!

On Mon, 25 Jul 2016, EI wrote:

> If you build from source and would like to help with a bit of testing,= my
> branch
>
> https://phabricator.k= de.org/diffusion/KRITA/browse/thumbnail_improvements/
>
> is ready for wider testing. It adds histogram docker and a bit of &quo= t;eye
> candy":
>
> 1. New histogram docker shows current image histogram. It can be enabl= ed
> from
>
> 2. Channel docker shows thumbnails of each color channel. You can use<= br> > checkmarks to enable/disable different color channels (but not alpha > channel). Double click on a channel row should disable all other color=
> channels.
>
> 3. Overview docker now has higher quality thumbnail (anti-aliased). >
> 4. All three dockers update with a slight delay (~1/4 sec) after you s= top
> painting to avoid interrupting paint operations.
>
> When testing please look for new slowdowns when painting, memory leaks= ,
> inconsistent behavior, etc.
>
> Thank you,
> Eugene
>

--
Boudewijn Rempt | http://www.krita.org, http://www.valdyas.org
_______________________________________________
Krita mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop=



--
Dmitry Kazakov
--001a114bddfe0248ad05388891f3-- --===============3161405109340048294== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS3JpdGEgbWFp bGluZyBsaXN0CmtpbWFnZXNob3BAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2tpbWFnZXNob3AK --===============3161405109340048294==--