[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: [PATCH]: fix "merge with layer below" junior job
From: Timothée_Giet <animtim () gmail ! com>
Date: 2014-02-14 11:52:11
Message-ID: 52FE036B.4060308 () gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi Gaurav,
I've tested the patch, it does indeed fix merging alpha-disabled-layer
on a "normal" layer as it worked before the previous change.
But then it does break merging alpha-disabled-layer on another
alpha-disabled-layer that this previous change fixed (or at least tried
to as it broke the other case.. )
Cheers
Tim
Le 14/02/2014 02:17, GAURAV Agrawal a écrit :
> Hello,
>
> The attached patch applies to the file-calligra/krita/image/kis_image.cc
>
> This patch fixes the Bug-322951
>
> https://bugs.kde.org/show_bug.cgi?id=322951.
>
> It fixes the bug that when we try to merge two layers in which the
> layer above inherits alpha and the layer below doesn't inherit alpha,
> it doesn't give the desired results.
>
> This patch will give the desired result that the final merged image
> will contain the part of the layer above ,within the visible coloured
> part of the layer below .There is no extra scattered part.
>
> Thanks,
>
> Gaurav
>
>
>
>
> _______________________________________________
> Krita mailing list
> kimageshop@kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
[Attachment #5 (text/html)]
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi Gaurav,<br>
<br>
I've tested the patch, it does indeed fix merging
alpha-disabled-layer on a "normal" layer as it worked before the
previous change.<br>
But then it does break merging alpha-disabled-layer on another
alpha-disabled-layer that this previous change fixed (or at least
tried to as it broke the other case.. )<br>
<br>
Cheers<br>
Tim<br>
<br>
Le 14/02/2014 02:17, GAURAV Agrawal a écrit :<br>
</div>
<blockquote
cite="mid:CA+cBbmXn63X2G5Oz9Xxw_P8RvhfCnnM9TKvZ_8P-mFZaHxBErA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>
<div>
<div>
<div>
<div>Hello,<br>
<br>
</div>
The attached patch applies to the
file-calligra/krita/image/kis_image.cc<br>
<br>
</div>
This patch fixes the Bug-322951<br>
<br>
\
<a moz-do-not-send="true"
href="https://bugs.kde.org/show_bug.cgi?id=322951">https://bugs.kde.org/show_bug.cgi?id=322951</a>.<br>
<br>
</div>
It fixes the bug that when we try to merge two layers in
which the layer above inherits alpha and the layer below
doesn't inherit alpha, it doesn't give the desired
results.<br>
<br>
</div>
This patch will give the desired result that the final
merged image will contain the part of the layer above
,within the visible coloured part of the layer below .There
is no extra scattered part.<br>
<br>
</div>
Thanks,<br>
<br>
</div>
Gaurav<br>
<div>
<div>
<div>
<div>
<div>
<div><br>
<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Krita mailing list
<a class="moz-txt-link-abbreviated" \
href="mailto:kimageshop@kde.org">kimageshop@kde.org</a> <a \
class="moz-txt-link-freetext" \
href="https://mail.kde.org/mailman/listinfo/kimageshop">https://mail.kde.org/mailman/listinfo/kimageshop</a>
</pre>
</blockquote>
<br>
</body>
</html>
_______________________________________________
Krita mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic