From kde-kimageshop Fri Feb 14 11:52:11 2014 From: =?ISO-8859-1?Q?Timoth=E9e_Giet?= Date: Fri, 14 Feb 2014 11:52:11 +0000 To: kde-kimageshop Subject: Re: [PATCH]: fix "merge with layer below" junior job Message-Id: <52FE036B.4060308 () gmail ! com> X-MARC-Message: https://marc.info/?l=kde-kimageshop&m=139237882701280 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7488248224471684577==" This is a multi-part message in MIME format. --===============7488248224471684577== Content-Type: multipart/alternative; boundary="------------090500000301080301050701" This is a multi-part message in MIME format. --------------090500000301080301050701 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Hi Gaurav, I've tested the patch, it does indeed fix merging alpha-disabled-layer on a "normal" layer as it worked before the previous change. But then it does break merging alpha-disabled-layer on another alpha-disabled-layer that this previous change fixed (or at least tried to as it broke the other case.. ) Cheers Tim Le 14/02/2014 02:17, GAURAV Agrawal a écrit : > Hello, > > The attached patch applies to the file-calligra/krita/image/kis_image.cc > > This patch fixes the Bug-322951 > > https://bugs.kde.org/show_bug.cgi?id=322951. > > It fixes the bug that when we try to merge two layers in which the > layer above inherits alpha and the layer below doesn't inherit alpha, > it doesn't give the desired results. > > This patch will give the desired result that the final merged image > will contain the part of the layer above ,within the visible coloured > part of the layer below .There is no extra scattered part. > > Thanks, > > Gaurav > > > > > _______________________________________________ > Krita mailing list > kimageshop@kde.org > https://mail.kde.org/mailman/listinfo/kimageshop --------------090500000301080301050701 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit

Hi Gaurav,

I've tested the patch, it does indeed fix merging alpha-disabled-layer on a "normal" layer as it worked before the previous change.
But then it does break merging alpha-disabled-layer on another alpha-disabled-layer that this previous change fixed (or at least tried to as it broke the other case.. )

Cheers
Tim

Le 14/02/2014 02:17, GAURAV Agrawal a écrit :

Hello,

The attached patch applies to the file-calligra/krita/image/kis_image.cc

This patch fixes the Bug-322951

https://bugs.kde.org/show_bug.cgi?id=322951.

It fixes the bug that when we try to merge two layers in which the layer above inherits alpha and the layer below doesn't inherit alpha, it doesn't give the desired results.

This patch will give the desired result that the final merged image will contain the part of the layer above ,within the visible coloured part of the layer below .There is no extra scattered part.

Thanks,

Gaurav
_______________________________________________
Krita mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop

--------------090500000301080301050701-- --===============7488248224471684577== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Krita mailing list kimageshop@kde.org https://mail.kde.org/mailman/listinfo/kimageshop --===============7488248224471684577==--