[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: [calligra] krita/ui/input: Don't try to copy an empty event
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2013-10-31 6:27:30
Message-ID: CAEkBSfUTkrwA-uC5C2aEwXc-VDK10n8UrgcYQGGOW-ruXSuGXA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


I guess, this bug is *not* in the KisAlternateInvocationAction, but in the
KisShortcutMatcher. It must not emit null events! This 'if' must be changed
to an ASSERT actually.


On Wed, Oct 30, 2013 at 6:40 PM, Boudewijn Rempt <boud@valdyas.org> wrote:

> Git commit 17dee1751eaa38187d1151e2f71ba2cb6ae0e514 by Boudewijn Rempt.
> Committed on 30/10/2013 at 13:24.
> Pushed by rempt into branch 'master'.
>
> Don't try to copy an empty event
>
> BUG:326762
>
> M  +4    -0    krita/ui/input/kis_alternate_invocation_action.cpp
>
> http://commits.kde.org/calligra/17dee1751eaa38187d1151e2f71ba2cb6ae0e514
>
> diff --git a/krita/ui/input/kis_alternate_invocation_action.cpp
> b/krita/ui/input/kis_alternate_invocation_action.cpp
> index bdfe546..002ca42 100644
> --- a/krita/ui/input/kis_alternate_invocation_action.cpp
> +++ b/krita/ui/input/kis_alternate_invocation_action.cpp
> @@ -47,6 +47,8 @@ int KisAlternateInvocationAction::priority() const
>
>  void KisAlternateInvocationAction::begin(int shortcut, QEvent *event)
>  {
> +    if (!event) return;
> +
>      KisAbstractInputAction::begin(shortcut, event);
>
>      QMouseEvent *mouseEvent = dynamic_cast<QMouseEvent*>(event);
> @@ -68,6 +70,8 @@ void KisAlternateInvocationAction::begin(int shortcut,
> QEvent *event)
>
>  void KisAlternateInvocationAction::end(QEvent *event)
>  {
> +    if (!event) return;
> +
>      QMouseEvent *mouseEvent = dynamic_cast<QMouseEvent*>(event);
>
>      QMouseEvent targetEvent(*mouseEvent);
>
>


-- 
Dmitry Kazakov

[Attachment #5 (text/html)]

<div dir="ltr">I guess, this bug is *not* in the KisAlternateInvocationAction, but in \
the KisShortcutMatcher. It must not emit null events! This &#39;if&#39; must be \
changed to an ASSERT actually.<br></div><div class="gmail_extra"> <br><br><div \
class="gmail_quote">On Wed, Oct 30, 2013 at 6:40 PM, Boudewijn Rempt <span \
dir="ltr">&lt;<a href="mailto:boud@valdyas.org" \
target="_blank">boud@valdyas.org</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Git commit 17dee1751eaa38187d1151e2f71ba2cb6ae0e514 by \
Boudewijn Rempt.<br> Committed on 30/10/2013 at 13:24.<br>
Pushed by rempt into branch &#39;master&#39;.<br>
<br>
Don&#39;t try to copy an empty event<br>
<br>
BUG:326762<br>
<br>
M   +4      -0      krita/ui/input/kis_alternate_invocation_action.cpp<br>
<br>
<a href="http://commits.kde.org/calligra/17dee1751eaa38187d1151e2f71ba2cb6ae0e514" \
target="_blank">http://commits.kde.org/calligra/17dee1751eaa38187d1151e2f71ba2cb6ae0e514</a><br>
 <br>
diff --git a/krita/ui/input/kis_alternate_invocation_action.cpp \
b/krita/ui/input/kis_alternate_invocation_action.cpp<br> index bdfe546..002ca42 \
                100644<br>
--- a/krita/ui/input/kis_alternate_invocation_action.cpp<br>
+++ b/krita/ui/input/kis_alternate_invocation_action.cpp<br>
@@ -47,6 +47,8 @@ int KisAlternateInvocationAction::priority() const<br>
<br>
  void KisAlternateInvocationAction::begin(int shortcut, QEvent *event)<br>
  {<br>
+      if (!event) return;<br>
+<br>
        KisAbstractInputAction::begin(shortcut, event);<br>
<br>
        QMouseEvent *mouseEvent = dynamic_cast&lt;QMouseEvent*&gt;(event);<br>
@@ -68,6 +70,8 @@ void KisAlternateInvocationAction::begin(int shortcut, QEvent \
*event)<br> <br>
  void KisAlternateInvocationAction::end(QEvent *event)<br>
  {<br>
+      if (!event) return;<br>
+<br>
        QMouseEvent *mouseEvent = dynamic_cast&lt;QMouseEvent*&gt;(event);<br>
<br>
        QMouseEvent targetEvent(*mouseEvent);<br>
<br>
</blockquote></div><br><br clear="all"><br>-- <br>Dmitry Kazakov
</div>



_______________________________________________
Krita mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]